servius/songbird
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix(ci): Move problem tests purely to cargo make test (#250)

Browse Source 
A few tests are routinely failing on CI because they explicitly
hit YouTube URLs, even if the content in question is CC-licensed.
This PR simply adds the `#[ignore]` attribute, and adds the
`--include-ignored` flag to `cargo make test` so that correct WebM
parsing behaviour can be locally verified.

We could go a bit further and conditionally ignore the tests based
on CI-specific ENV vars, but that's probably overkill given the
scope of the issue.
This commit is contained in:
Kyle Simpson
2024-08-24 23:11:37 +01:00
committed by GitHub
parent 530286c6a6
commit 0844537024
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile.toml
View File

@@ -41,7 +41,7 @@ args = ["clippy", "--features", "full-doc", "--", "-D", "warnings"]
dependencies = ["format"] dependencies = ["format"]
[tasks.test] [tasks.test]
args = ["test", "--features", "full-doc"] args = ["test", "--features", "full-doc", "--", "--include-ignored"]
[tasks.test-simd] [tasks.test-simd]
args = ["test", "--features", "full-doc,simd-json,serenity?/simd_json,twilight-gateway?/simd-json"] args = ["test", "--features", "full-doc,simd-json,serenity?/simd_json,twilight-gateway?/simd-json"]

3
src/input/sources/ytdl.rs
View File

@@ -247,6 +247,7 @@ mod tests {
} }
#[tokio::test] #[tokio::test]
#[ignore]
#[ntest::timeout(20_000)] #[ntest::timeout(20_000)]
async fn ytdl_page_with_playlist_plays() { async fn ytdl_page_with_playlist_plays() {
track_plays_passthrough(|| YoutubeDl::new(Client::new(), YTDL_PLAYLIST_TARGET.into())) track_plays_passthrough(|| YoutubeDl::new(Client::new(), YTDL_PLAYLIST_TARGET.into()))
@@ -274,6 +275,7 @@ mod tests {
} }
#[tokio::test] #[tokio::test]
#[ignore]
#[ntest::timeout(20_000)] #[ntest::timeout(20_000)]
async fn ytdl_search_plays() { async fn ytdl_search_plays() {
let mut ytdl = YoutubeDl::new_search(Client::new(), "cloudkicker 94 days".into()); let mut ytdl = YoutubeDl::new_search(Client::new(), "cloudkicker 94 days".into());
@@ -286,6 +288,7 @@ mod tests {
} }
#[tokio::test] #[tokio::test]
#[ignore]
#[ntest::timeout(20_000)] #[ntest::timeout(20_000)]
async fn ytdl_search_3() { async fn ytdl_search_3() {
let mut ytdl = YoutubeDl::new_search(Client::new(), "test".into()); let mut ytdl = YoutubeDl::new_search(Client::new(), "test".into());