fix(source): HLS would not work if used directly. (#262)

This changes HlsRequest to return true in
Compose::should_create_async.

This would otherwise cause it to be spawned on a thread without a
executor causing it to panic.

This would only cause issues if used directly since we otherwise use
Compose::create in a context where we have access to the executor.
This commit is contained in:
Erk
2024-11-15 05:47:06 +01:00
committed by GitHub
parent 8eace22e25
commit 312799d231

View File

@@ -16,6 +16,11 @@ use crate::input::{
}; };
/// Lazy HLS stream /// Lazy HLS stream
///
/// # Note:
///
/// `Compose::create` for this struct panics if called outside of a
/// tokio executor since it uses background tasks.
#[derive(Debug)] #[derive(Debug)]
pub struct HlsRequest { pub struct HlsRequest {
/// HTTP client /// HTTP client
@@ -82,11 +87,11 @@ impl Compose for HlsRequest {
async fn create_async( async fn create_async(
&mut self, &mut self,
) -> Result<AudioStream<Box<dyn MediaSource>>, AudioStreamError> { ) -> Result<AudioStream<Box<dyn MediaSource>>, AudioStreamError> {
Err(AudioStreamError::Unsupported) self.create()
} }
fn should_create_async(&self) -> bool { fn should_create_async(&self) -> bool {
false true
} }
} }