From c8ddfb444af129ad5bba891b16e9c41fafaff881 Mon Sep 17 00:00:00 2001
From: Timothy DeHerrera <tim@nrdxp.dev>
Date: Fri, 6 Feb 2026 00:33:10 -0700
Subject: [PATCH] refactor: remove test redundancy, reduce API surface

- Remove duplicate xml_escape tests from sitemap.rs and feed.rs
  (already tested in escape.rs)
- Make html_escape_into private (only used internally)
---
 src/escape.rs  |  2 +-
 src/feed.rs    | 11 -----------
 src/sitemap.rs |  8 --------
 3 files changed, 1 insertion(+), 20 deletions(-)

diff --git a/src/escape.rs b/src/escape.rs
index 8dac100..ffe841f 100644
--- a/src/escape.rs
+++ b/src/escape.rs
@@ -12,7 +12,7 @@ pub fn html_escape(s: &str) -> String {
 /// Escape HTML characters into an existing string.
 ///
 /// This is more efficient when building output incrementally.
-pub fn html_escape_into(out: &mut String, s: &str) {
+fn html_escape_into(out: &mut String, s: &str) {
     for c in s.chars() {
         match c {
             '&' => out.push_str("&amp;"),
diff --git a/src/feed.rs b/src/feed.rs
index a182c72..4bef9bd 100644
--- a/src/feed.rs
+++ b/src/feed.rs
@@ -80,14 +80,3 @@ pub fn generate_atom_feed(
         entries,
     )
 }
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn test_xml_escape() {
-        assert_eq!(xml_escape("Hello & World"), "Hello &amp; World");
-        assert_eq!(xml_escape("<tag>"), "&lt;tag&gt;");
-    }
-}
diff --git a/src/sitemap.rs b/src/sitemap.rs
index d00b9d5..9acbac2 100644
--- a/src/sitemap.rs
+++ b/src/sitemap.rs
@@ -93,14 +93,6 @@ fn build_sitemap_xml(entries: &[SitemapEntry]) -> String {
 mod tests {
     use super::*;
 
-    #[test]
-    fn test_xml_escape() {
-        assert_eq!(xml_escape("Hello & World"), "Hello &amp; World");
-        assert_eq!(xml_escape("<tag>"), "&lt;tag&gt;");
-        assert_eq!(xml_escape("\"quoted\""), "&quot;quoted&quot;");
-        assert_eq!(xml_escape("it's"), "it&apos;s");
-    }
-
     #[test]
     fn test_build_sitemap_xml_single_entry() {
         let entries = vec![SitemapEntry {