Release v0.3.4

readme: Add flathub badge
Update dependencies, fix segmentation fault
2026-03-15 19:46:10 +08:00 · 2022-02-02 10:08:12 +01:00 · 2022-01-31 13:32:03 +01:00 · 2022-01-31 13:17:55 +01:00 · 2022-01-28 13:49:49 +01:00 · 2022-01-28 13:49:49 +01:00
32 changed files with 5602 additions and 782 deletions
--- a/.gitignore
+++ b/.gitignore
@@ -1,2 +1,3 @@
 /.flatpak-builder
 /.vscode
 /target
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -0,0 +1,75 @@
 include:
  - project: 'freedesktop/ci-templates'             # the project to include from
    ref: '34f4ade99434043f88e164933f570301fd18b125' # git ref of that project
    file: '/templates/fedora.yml'                   # the actual file to include
 stages:
  - prepare
  - lint
  - test
  - extras
 variables:
  FDO_UPSTREAM_REPO: 'pipewire/helvum'
 # Version and tag for our current container
 .fedora:
  variables:
    FDO_DISTRIBUTION_VERSION: '35'
    # Update this to trigger a container rebuild
    FDO_DISTRIBUTION_TAG: '2021-11-23.0'
 build-fedora-container:
  extends:
  - .fedora                            # our template job above
  - .fdo.container-build@fedora@x86_64 # the CI template
  stage: prepare
  variables:
    # clang-devel: required by rust bindgen
    FDO_DISTRIBUTION_PACKAGES: >-
      rust
      cargo
      rustfmt
      clippy
      pipewire-devel
      gtk4-devel
      clang-devel
 rustfmt:
  extends:
    - .fedora
    - .fdo.distribution-image@fedora
  stage: lint
  script:
    - cargo fmt --version
    - cargo fmt -- --color=always --check
 test-stable:
  extends:
    - .fedora
    - .fdo.distribution-image@fedora
  stage: test
  script:
    - rustc --version
    - cargo build --color=always --all-targets
    - cargo test --color=always
 rustdoc:
  extends:
    - .fedora
    - .fdo.distribution-image@fedora
  stage: extras
  variables:
    RUSTDOCFLAGS: '-Dwarnings'
  script:
    - rustdoc --version
    - cargo doc --no-deps
 clippy:
  extends:
    - .fedora
    - .fdo.distribution-image@fedora
  stage: extras
  script:
    - cargo clippy --version
    - cargo clippy --color=always --all-targets -- -D warnings
--- a/Cargo.lock
+++ b/Cargo.lock
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,14 +1,23 @@
 [package]
-name = "graphui"
+name = "helvum"
-version = "0.1.0"
+version = "0.3.4"
 authors = ["Tom A. Wagner <tom.a.wagner@protonmail.com>"]
-edition = "2018"
+edition = "2021"
 rust-version = "1.56"
 license = "GPL-3.0-only"
 description = "A GTK patchbay for pipewire"
 repository = "https://gitlab.freedesktop.org/pipewire/helvum"
 readme = "README.md"
 keywords = ["pipewire", "gtk", "patchbay", "gui", "utility"]
 categories = ["gui", "multimedia"]
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 [dependencies]
-pipewire = { git = "https://gitlab.freedesktop.org/gdesmott/pipewire-rs", branch = "proxies"}
+pipewire = "0.4"
-gtk = { git = "https://github.com/gtk-rs/gtk4-rs/", package = "gtk4" }
+gtk = { version = "0.4.1", package = "gtk4" }
 glib = { version = "0.15.1", features = ["log"] }
 log = "0.4.11"
-env_logger = "0.8.2"
+
 once_cell = "1.7.2"
--- a/14
+++ b/14
@@ -1,7 +1,7 @@
                    GNU GENERAL PUBLIC LICENSE
                       Version 3, 29 June 2007
- Copyright (C) 2007 Free Software Foundation, Inc. <http://fsf.org/>
+ Copyright (C) 2007 Free Software Foundation, Inc. <https://fsf.org/>
 Everyone is permitted to copy and distribute verbatim copies
 of this license document, but changing it is not allowed.
@@ -631,8 +631,8 @@ to attach them to the start of each source file to most effectively
 state the exclusion of warranty; and each file should have at least
 the "copyright" line and a pointer to where the full notice is found.
-    Pipewire Graphui
+    <one line to give the program's name and a brief idea of what it does.>
-    Copyright (C) 2020  Ryuukyu
+    Copyright (C) <year>  <name of author>
    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -645,14 +645,14 @@ the "copyright" line and a pointer to where the full notice is found.
    GNU General Public License for more details.
    You should have received a copy of the GNU General Public License
-    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+    along with this program.  If not, see <https://www.gnu.org/licenses/>.
 Also add information on how to contact you by electronic and paper mail.
  If the program does terminal interaction, make it output a short
 notice like this when it starts in an interactive mode:
-    Pipewire Graphui  Copyright (C) 2020  Ryuukyu
+    <program>  Copyright (C) <year>  <name of author>
    This program comes with ABSOLUTELY NO WARRANTY; for details type `show w'.
    This is free software, and you are welcome to redistribute it
    under certain conditions; type `show c' for details.
@@ -664,11 +664,11 @@ might be different; for a GUI interface, you would use an "about box".
  You should also get your employer (if you work as a programmer) or school,
 if any, to sign a "copyright disclaimer" for the program, if necessary.
 For more information on this, and how to apply and follow the GNU GPL, see
-<http://www.gnu.org/licenses/>.
+<https://www.gnu.org/licenses/>.
  The GNU General Public License does not permit incorporating your program
 into proprietary programs.  If your program is a subroutine library, you
 may consider it more useful to permit linking proprietary applications with
 the library.  If this is what you want to do, use the GNU Lesser General
 Public License instead of this License.  But first, please read
-<http://www.gnu.org/philosophy/why-not-lgpl.html>.
+<https://www.gnu.org/licenses/why-not-lgpl.html>.
--- a/README.md
+++ b/README.md
@@ -1,23 +1,63 @@
-A graphical interface for viewing the current pipewire graph (name pending, suggestions welcome), inspired by the JACK tool [catia](https://kx.studio/Applications:Catia).
+Helvum is a GTK-based patchbay for pipewire, inspired by the JACK tool [catia](https://kx.studio/Applications:Catia).
-![Screenshot](screenshot.png)
+![Screenshot](docs/screenshot.png)
 <a href="https://flathub.org/apps/details/org.pipewire.Helvum"><img src="https://flathub.org/assets/badges/flathub-badge-en.png" width="300"/></a>
 <a href="https://repology.org/project/helvum/versions"><img src="https://repology.org/badge/vertical-allrepos/helvum.svg" width="300"/></a>
 # Features planned
- Allow creation of links from one port to another.
+- Volume control
- Color ports and links based on whether they carry audio, video or midi data.
+- "Debug mode" that lets you view advanced information for nodes and ports
 More suggestions are welcome!
 # Building
 ## Via flatpak
 If you don't have the flathub repo in your remote-list for flatpak you will need to add that first:
 ```shell
 $ flatpak remote-add --if-not-exists flathub https://flathub.org/repo/flathub.flatpakrepo
 ```
 Then install the required flatpak platform and SDK, if you dont have them already:
 ```shell
 $ flatpak install org.gnome.{Platform,Sdk}//41 org.freedesktop.Sdk.Extension.rust-stable//21.08 org.freedesktop.Sdk.Extension.llvm12//21.08
 ```
 To compile and install as a flatpak, clone the project, change to the project directory, and run:
 ```shell
 $ flatpak-builder --install flatpak-build/ build-aux/org.pipewire.Helvum.json
 ```
 You can then run the app via
 ```shell
 $ flatpak run org.pipewire.Helvum
 ```
 ## Manually
 For compilation, you will need:
 - Meson
 - An up-to-date rust toolchain
- gtk-4.0 and pipewire-0.3 development headers
+- `libclang-3.7` or higher
 - `gtk-4.0` and `pipewire-0.3` development headers
-To compile, run
+To compile and install, run
-    $ cargo build --release
+```shell
 $ meson setup build && cd build
 $ meson compile
 $ meson install
 ```
 in the repository root.
-The resulting binary will be at `target/release/graphui`.
+This will install the compiled project files into `/usr/local`.
 # License and Credits
 Helvum is distributed under the terms of the GPL3 license.
 See LICENSE for more information.
 Parts of the build system were taken from the [gtk-rust-template](https://gitlab.gnome.org/World/Rust/gtk-rust-template) project,
 which is provided under the terms of the [MIT license](https://gitlab.gnome.org/World/Rust/gtk-rust-template/-/blob/master/LICENSE.md).
--- a/build-aux/dist-vendor.sh
+++ b/build-aux/dist-vendor.sh
@@ -0,0 +1,12 @@
 #!/usr/bin/env bash
 set -euo pipefail
 export DIST="$1"
 export SOURCE_ROOT="$2"
 cd "$SOURCE_ROOT"
 mkdir "$DIST"/.cargo
 cargo vendor > $DIST/.cargo/config
 # Move vendor into dist tarball directory
 mv vendor "$DIST"
--- a/build-aux/org.pipewire.Helvum.json
+++ b/build-aux/org.pipewire.Helvum.json
@@ -0,0 +1,40 @@
 {
    "app-id": "org.pipewire.Helvum",
    "runtime": "org.gnome.Platform",
    "runtime-version": "41",
    "sdk": "org.gnome.Sdk",
    "sdk-extensions": [
        "org.freedesktop.Sdk.Extension.rust-stable",
        "org.freedesktop.Sdk.Extension.llvm12"
    ],
    "command": "helvum",
    "finish-args": [
        "--socket=fallback-x11",
        "--socket=wayland",
        "--device=dri",
        "--share=ipc",
        "--filesystem=xdg-run/pipewire-0"
    ],
    "build-options": {
        "append-path": "/usr/lib/sdk/rust-stable/bin:/usr/lib/sdk/llvm12/bin",
        "prepend-ld-library-path": "/usr/lib/sdk/llvm12/lib",
        "build-args": [
            "--share=network"
        ]
    },
    "modules": [
        {
            "name": "Helvum",
            "buildsystem": "meson",
            "sources": [
                {
                    "type": "dir",
                    "path": "../"
                }
            ],
            "config-opts": [
                "-Dprofile=development"
            ]
        }
    ]
 }
--- a/data/icons/meson.build
+++ b/data/icons/meson.build
@@ -0,0 +1,9 @@
 install_data(
  '@0@.svg'.format(base_id),
  install_dir: iconsdir / 'hicolor' / 'scalable' / 'apps'
 )
 install_data(
  '@0@-symbolic.svg'.format(base_id),
  install_dir: iconsdir / 'hicolor' / 'symbolic' / 'apps',
 )
--- a/data/icons/org.pipewire.Helvum-symbolic.svg
+++ b/data/icons/org.pipewire.Helvum-symbolic.svg
@@ -0,0 +1,8 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <svg height="16px" viewBox="0 0 16 16" width="16px" xmlns="http://www.w3.org/2000/svg">
    <path d="m 3.5 2.5 h 9 c 1.378906 0 2.5 1.121094 2.5 2.5 v 5 c 0 1.378906 -1.121094 2.5 -2.5 2.5 h -9 c -1.378906 0 -2.5 -1.121094 -2.5 -2.5 v -5 c 0 -1.378906 1.121094 -2.5 2.5 -2.5 z m 0 0" fill="#241f31" fill-rule="evenodd"/>
    <g fill="none" stroke="#8a8891">
        <path d="m 11 7.5 h -6"/>
        <path d="m 5 7.5 c 0 -4.15625 -1.382812 -10.855469 -3.90625 -13.25" stroke-linecap="round" stroke-linejoin="bevel" stroke-width="4"/>
    </g>
 </svg>
--- a/data/icons/org.pipewire.Helvum.Source.svg
+++ b/data/icons/org.pipewire.Helvum.Source.svg
--- a/data/icons/org.pipewire.Helvum.svg
+++ b/data/icons/org.pipewire.Helvum.svg
@@ -0,0 +1,56 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <svg height="128px" viewBox="0 0 128 128" width="128px" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
    <linearGradient id="a" gradientUnits="userSpaceOnUse">
        <stop offset="0" stop-color="#9a9996"/>
        <stop offset="0.5" stop-color="#c0bfbc"/>
        <stop offset="1" stop-color="#deddda"/>
    </linearGradient>
    <linearGradient id="b" x1="26.263471" x2="26.263586" xlink:href="#a" y1="24.848538" y2="37.1125"/>
    <linearGradient id="c" gradientUnits="userSpaceOnUse" x1="7.39555839647" x2="120.60350567947" y1="82.86737386462" y2="82.86737386462">
        <stop offset="0" stop-color="#5e5c64"/>
        <stop offset="0.0384615" stop-color="#77767b"/>
        <stop offset="0.0768555" stop-color="#5e5c64"/>
        <stop offset="0.923077" stop-color="#5e5c64"/>
        <stop offset="0.961538" stop-color="#77767b"/>
        <stop offset="1" stop-color="#5e5c64"/>
    </linearGradient>
    <linearGradient id="d" gradientTransform="matrix(2.571428 0 0 2.454545 22.856596 -228.048061)" x1="16" x2="16" xlink:href="#a" y1="121.582512" y2="127.082512"/>
    <linearGradient id="e" gradientTransform="matrix(2.571428 0 0 2.454545 22.856596 -253.563246)" x1="16" x2="16" xlink:href="#a" y1="121.582512" y2="127.082512"/>
    <linearGradient id="f" gradientTransform="matrix(2.571428 0 0 2.454545 60.592569 -253.563246)" x1="16" x2="16" xlink:href="#a" y1="121.582512" y2="127.082512"/>
    <linearGradient id="g" gradientTransform="matrix(2.571428 0 0 2.454545 60.592569 -228.048061)" x1="16" x2="16" xlink:href="#a" y1="121.582512" y2="127.082512"/>
    <linearGradient id="h" gradientTransform="matrix(2.358499 0 0 2.251294 -11.472502 -204.652927)" gradientUnits="userSpaceOnUse" x1="12.5" x2="19.5" y1="113.832512" y2="113.832512">
        <stop offset="0" stop-color="#c0bfbc"/>
        <stop offset="0.5" stop-color="#9a9996"/>
        <stop offset="1" stop-color="#c0bfbc"/>
    </linearGradient>
    <linearGradient id="i" gradientTransform="matrix(2.571428 0 0 2.454545 -14.879853 -228.048061)" x1="16" x2="16" xlink:href="#a" y1="121.582512" y2="127.082512"/>
    <path d="m 34.519531 30.980469 c 0 3.386719 -3.695312 6.132812 -8.257812 6.132812 c -4.558594 0 -8.253907 -2.746093 -8.253907 -6.132812 s 3.695313 -6.132813 8.253907 -6.132813 c 4.5625 0 8.257812 2.746094 8.257812 6.132813 z m 0 0" fill="url(#b)" fill-rule="evenodd"/>
    <path d="m 120.601562 82.867188 v 18.867187 c 0 5.226563 -4.207031 9.433594 -9.433593 9.433594 h -94.339844 c -5.226563 0 -9.433594 -4.207031 -9.433594 -9.433594 v -18.867187 z m 0 0" fill="url(#c)" fill-rule="evenodd"/>
    <path d="m 16.828125 35.699219 c -5.226563 0 -9.433594 4.207031 -9.433594 9.433593 v 37.734376 c 0 5.226562 4.207031 9.433593 9.433594 9.433593 h 94.339844 c 5.226562 0 9.4375 -4.207031 9.4375 -9.433593 v -37.734376 c 0 -5.226562 -4.210938 -9.433593 -9.4375 -9.433593 h -76.648438 v 2.355469 h -16.511719 v -2.355469 z m 0 0" fill="#77767b" fill-rule="evenodd"/>
    <path d="m 93.480469 76.378906 l -30.660157 -24.761718" fill="none" stroke="#77767b" stroke-linecap="square" stroke-width="3.74412"/>
    <path d="m 64 58.691406 v 10.613282" fill="none" stroke="#999999" stroke-width="1.5"/>
    <g fill-rule="evenodd">
        <path d="m 75 77.132812 c 0 4.554688 -4.925781 8.25 -11 8.25 s -11 -3.695312 -11 -8.25 c 0 -4.558593 4.925781 -8.25 11 -8.25 s 11 3.691407 11 8.25 z m 0 0" fill="#e01b24"/>
        <path d="m 73 77.132812 c 0 3.726563 -4.03125 6.75 -9 6.75 c -4.972656 0 -9 -3.023437 -9 -6.75 c 0 -3.730468 4.027344 -6.75 9 -6.75 c 4.96875 0 9 3.019532 9 6.75 z m 0 0" fill="url(#d)"/>
        <path d="m 71 77.132812 c 0 2.898438 -3.132812 5.25 -7 5.25 s -7 -2.351562 -7 -5.25 c 0 -2.902343 3.132812 -5.25 7 -5.25 s 7 2.347657 7 5.25 z m 0 0" fill="#3d3846"/>
        <path d="m 75 51.617188 c 0 4.554687 -4.925781 8.25 -11 8.25 s -11 -3.695313 -11 -8.25 c 0 -4.558594 4.925781 -8.25 11 -8.25 s 11 3.691406 11 8.25 z m 0 0" fill="#1c71d8"/>
        <path d="m 73 51.617188 c 0 3.726562 -4.03125 6.75 -9 6.75 c -4.972656 0 -9 -3.023438 -9 -6.75 c 0 -3.730469 4.027344 -6.75 9 -6.75 c 4.96875 0 9 3.019531 9 6.75 z m 0 0" fill="url(#e)"/>
        <path d="m 71 51.617188 c 0 2.898437 -3.132812 5.25 -7 5.25 s -7 -2.351563 -7 -5.25 c 0 -2.898438 3.132812 -5.25 7 -5.25 s 7 2.351562 7 5.25 z m 0 0" fill="#3d3846"/>
        <path d="m 112.734375 51.617188 c 0 4.554687 -4.921875 8.25 -11 8.25 c -6.074219 0 -11 -3.695313 -11 -8.25 c 0 -4.558594 4.925781 -8.25 11 -8.25 c 6.078125 0 11 3.691406 11 8.25 z m 0 0" fill="#1c71d8"/>
        <path d="m 110.734375 51.617188 c 0 3.726562 -4.027344 6.75 -9 6.75 c -4.96875 0 -9 -3.023438 -9 -6.75 c 0 -3.730469 4.03125 -6.75 9 -6.75 c 4.972656 0 9 3.019531 9 6.75 z m 0 0" fill="url(#f)"/>
        <path d="m 108.734375 51.617188 c 0 2.898437 -3.132813 5.25 -7 5.25 c -3.863281 0 -7 -2.351563 -7 -5.25 c 0 -2.898438 3.136719 -5.25 7 -5.25 c 3.867187 0 7 2.351562 7 5.25 z m 0 0" fill="#3d3846"/>
    </g>
    <path d="m 101.734375 58.691406 v 10.613282" fill="none" stroke="#999999" stroke-width="1.5"/>
    <path d="m 112.734375 77.132812 c 0 4.554688 -4.921875 8.25 -11 8.25 c -6.074219 0 -11 -3.695312 -11 -8.25 c 0 -4.558593 4.925781 -8.25 11 -8.25 c 6.078125 0 11 3.691407 11 8.25 z m 0 0" fill="#e01b24" fill-rule="evenodd"/>
    <path d="m 110.734375 77.132812 c 0 3.726563 -4.027344 6.75 -9 6.75 c -4.96875 0 -9 -3.023437 -9 -6.75 c 0 -3.730468 4.03125 -6.75 9 -6.75 c 4.972656 0 9 3.019532 9 6.75 z m 0 0" fill="url(#g)" fill-rule="evenodd"/>
    <path d="m 108.734375 77.132812 c 0 2.898438 -3.132813 5.25 -7 5.25 c -3.863281 0 -7 -2.351562 -7 -5.25 c 0 -2.902343 3.136719 -5.25 7 -5.25 c 3.867187 0 7 2.347657 7 5.25 z m 0 0" fill="#3d3846" fill-rule="evenodd"/>
    <path d="m 26.261719 69.339844 v -10.648438" fill="none" stroke="#999999" stroke-width="1.5"/>
    <path d="m 37.261719 52.515625 c 0 4.238281 -4.921875 7.671875 -11 7.671875 c -6.074219 0 -11 -3.433594 -11 -7.671875 c 0 -4.234375 4.925781 -7.671875 11 -7.671875 c 6.078125 0 11 3.4375 11 7.671875 z m 0 0" fill="#1c71d8" fill-rule="evenodd"/>
    <path d="m 18.007812 30.980469 v 20.636719 c 0.003907 3.417968 3.699219 6.191406 8.253907 6.191406 c 4.554687 0 8.25 -2.765625 8.253906 -6.183594 c 0 0 0 -0.003906 0 -0.007812 v -20.636719 c -1.308594 2.597656 -4.589844 6.132812 -8.253906 6.132812 c -3.660157 0 -6.941407 -3.535156 -8.253907 -6.132812 z m 0 0" fill="url(#h)" fill-rule="evenodd"/>
    <path d="m 37.261719 77.132812 c 0 4.554688 -4.921875 8.25 -11 8.25 c -6.074219 0 -11 -3.695312 -11 -8.25 c 0 -4.558593 4.925781 -8.25 11 -8.25 c 6.078125 0 11 3.691407 11 8.25 z m 0 0" fill="#e01b24" fill-rule="evenodd"/>
    <path d="m 35.261719 77.132812 c 0 3.726563 -4.027344 6.75 -9 6.75 c -4.96875 0 -9 -3.023437 -9 -6.75 c 0 -3.730468 4.03125 -6.75 9 -6.75 c 4.972656 0 9 3.019532 9 6.75 z m 0 0" fill="url(#i)" fill-rule="evenodd"/>
    <path d="m 33.261719 77.132812 c 0 2.898438 -3.132813 5.25 -7 5.25 c -3.863281 0 -7 -2.351562 -7 -5.25 c 0 -2.902343 3.136719 -5.25 7 -5.25 c 3.867187 0 7 2.347657 7 5.25 z m 0 0" fill="#3d3846" fill-rule="evenodd"/>
    <path d="m 34.519531 30.980469 c 0 3.386719 -3.695312 6.132812 -8.257812 6.132812 c -4.558594 0 -8.253907 -2.746093 -8.253907 -6.132812 s 3.695313 -6.132813 8.253907 -6.132813 c 4.5625 0 8.257812 2.746094 8.257812 6.132813 z m 0 0" fill="#c0bfbc" fill-rule="evenodd"/>
    <path d="m 30.980469 30.980469 c 0 1.953125 -2.113281 3.539062 -4.71875 3.539062 c -2.601563 0 -4.714844 -1.585937 -4.714844 -3.539062 s 2.113281 -3.539063 4.714844 -3.539063 c 2.605469 0 4.71875 1.585938 4.71875 3.539063 z m 0 0" fill="#1a5fb4" fill-rule="evenodd"/>
    <path d="m 26.261719 30.980469 c 0 -7.074219 0.628906 -18.371094 -10.285157 -21.847657 c -11.828124 -3.765624 -33.882812 3 -33.882812 3" fill="none" stroke="#1a5fb4" stroke-width="9.434"/>
 </svg>
--- a/data/meson.build
+++ b/data/meson.build
@@ -0,0 +1,49 @@
 subdir('icons')
 desktop_conf = configuration_data()
 desktop_conf.set('icon', base_id)
 desktop_file = configure_file(
  input: '@0@.desktop.in'.format(base_id),
  output: '@BASENAME@',
  configuration: desktop_conf
 )
 if desktop_file_validate.found()
  test(
    'validate-desktop',
    desktop_file_validate,
    args: [
      desktop_file
    ],
  )
 endif
 install_data(
  desktop_file,
  install_dir: datadir / 'applications'
 )
 appdata_conf = configuration_data()
 appdata_conf.set('app-id', base_id)
 appdata_file = configure_file(
  input: '@0@.metainfo.xml.in'.format(base_id),
  output: '@BASENAME@',
  configuration: appdata_conf
 )
 # Validate Appdata
 if appstream_util.found()
  test(
    'validate-appdata',
    appstream_util,
    args: [
      'validate', '--nonet', appdata_file
    ],
  )
 endif
 install_data(
  appdata_file,
  install_dir: datadir / 'metainfo'
 )
--- a/data/org.pipewire.Helvum.desktop.in
+++ b/data/org.pipewire.Helvum.desktop.in
@@ -0,0 +1,9 @@
 [Desktop Entry]
 Name=Helvum
 GenericName=Patchbay
 Comment=A patchbay for pipewire
 Type=Application
 Exec=helvum
 Terminal=false
 Categories=AudioVideo;Audio;Video;Midi;Settings;GNOME;GTK;
 Icon=@icon@
--- a/data/org.pipewire.Helvum.metainfo.xml.in
+++ b/data/org.pipewire.Helvum.metainfo.xml.in
@@ -0,0 +1,41 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!-- Copyright 2021 Tom A. Wagner <tom.a.wagner@protonmail.com> -->
 <component type="desktop-application">
    <id>@app-id@</id>
    <metadata_license>CC-BY-SA-4.0</metadata_license>
    <project_license>GPL-3.0-only</project_license>
    <name>Helvum</name>
    <summary>Patchbay for PipeWire</summary>
    <description>
        <p>
            Helvum is a graphical patchbay for PipeWire.
            It allows creating and removing connections between applications and/or devices to reroute
            flow of audio, video and MIDI data to where it is needed.
        </p>
    </description>
    <screenshots>
        <screenshot type="default">
            <image>https://gitlab.freedesktop.org/pipewire/helvum/-/raw/main/docs/screenshot.png</image>
        </screenshot>
    </screenshots>
    <launchable type="desktop-id">@app-id@.desktop</launchable>
    <url type="homepage">https://gitlab.freedesktop.org/pipewire/helvum</url>
    <url type="bugtracker">https://gitlab.freedesktop.org/pipewire/helvum/-/issues</url>
    <content_rating type="oars-1.0" />
    <releases>
        <release version="0.3.4" date="2022-02-02" />
        <release version="0.3.3" date="2022-01-28" />
        <release version="0.3.2" date="2021-11-30" />
        <release version="0.3.1" date="2021-09-30" />
        <release version="0.3.0" date="2021-08-08" />
        <release version="0.2.1" date="2021-06-06" />
        <release version="0.2.0" date="2021-05-21" />
        <release version="0.1.0" date="2021-01-12" />
    </releases>
    <kudos>
        <kodu>HiDpiIcon</kodu>
        <kudo>ModernToolkit</kudo>
    </kudos>
    <developer_name>Tom A. Wagner</developer_name>
    <update_contact>tom.a.wagner@protonmail.com</update_contact>
 </component>
--- a/docs/architecture.md
+++ b/docs/architecture.md
@@ -0,0 +1,51 @@
 # Architecture
 If you want to understand the high-level architecture of helvum,
 this document is the right place.
 It provides a birds-eye view of the general architecture, and also goes into details on some
 components like the view.
 # Top Level Architecture
 Helvum uses an architecture with the components laid out like this:
 ```
 ┌──────┐
 │ GTK  │
 │ View │
 └────┬─┘
 Λ   ┆
 │<───── updates view                               ┌───────┐
 │   ┆                                              │ State │
 │   ┆<─ notifies of user input                     └───────┘
 │   ┆      (using signals)                             Λ
 │   ┆                                                  │
 │   ┆                                                  │<─── updates/reads state
 │   V           notifies of remote changes             │
 ┌┴────────────┐         via messages          ┌─────────┴─────────┐
 │ Application │<╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤     Seperate      │
 │   Object    ├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌>│  Pipewire Thread  │
 └─────────────┘   request changes to remote   └───────────────────┘
                        via messages                    Λ
                                                        ║
                                                        ║
                                                        V
                                            [ Remote Pipewire Server ]
 ```
 The program is split between two cooperating threads.
 The GTK thread (displayed on the left side) will sit in a GTK event processing loop, while the pipewire thread (displayed on the right side) will sit in a pipewire event processing loop.
 The `Application` object inside the GTK thread communicates with the pipewire thread using two channels,
 where each message sent by one thread will trigger the loop of the other thread to invoke a callback
 with the received message.
 For each change on the remote pipewire server, the pipewire thread updates the state and notifies
 the `Application` in the GTK thread if changes are needed.
 The `Application` then updates the view to reflect those changes.
 Additionally, a user may also make changes using the view.
 For each change, the view notifies the `Application` by emitting a matching signal.
 The `Application` will then ask the pipewire thread to make those changes on the remote. \
 These changes will then be applied to the view like any other remote changes as explained above.
 # View Architecture
 TODO
--- a/docs/making_a_release.md
+++ b/docs/making_a_release.md
@@ -0,0 +1,22 @@
 # Making a release
 The following describes the process of making a new release:
 1. In `data/org.pipewire.Helvum.metainfo.xml.in`,
   add a new `<release>` tag to the releases section with the appropriate version and date.
 2. In `meson.build` and `Cargo.toml`, bumb the projects version to the new version.
 3. Ensure cargo dependencies are up-to-date by running `cargo outdated` (may require running `cargo install cargo-outdated`) and updating outdated dependencies (including the versions specified in `Cargo.lock`).
 4. Commit the changes with the a message of the format "Release x.y.z"
 5. Add a tag to the release with the new version and a description from describing the changes as a message (run `git tag -a x.y.z`, then write the message)
 6. Make a **new** meson build directory and run `meson dist`.
   Two files should be created in a `meson-dist` subdirectory:
   `helvum-x.y.z.tar.xz` and 
   `helvum-x.y.z.tar.xz.sha256sum`
 7. Push the new commit and tag to upstream, then create a new release on gitlab from the new tag, the description from the tags message formatted as markdown, and also add the two files from step 6 to the description.
--- a/docs/screenshot.png
+++ b/docs/screenshot.png
--- a/meson.build
+++ b/meson.build
@@ -0,0 +1,38 @@
 project(
  'helvum',
  'rust',
  version: '0.3.4',
  license: 'GPL-3.0',
  meson_version: '>=0.59.0'
 )
 gnome = import('gnome')
 base_id = 'org.pipewire.Helvum'
 dependency('glib-2.0', version: '>= 2.66')
 dependency('gtk4',     version: '>= 4.4.0')
 dependency('libpipewire-0.3')
 desktop_file_validate = find_program('desktop-file-validate', required: false)
 appstream_util = find_program('appstream-util', required: false)
 cargo = find_program('cargo', required: true)
 prefix = get_option('prefix')
 bindir = prefix / get_option('bindir')
 datadir = prefix / get_option('datadir')
 iconsdir = datadir / 'icons'
 meson.add_dist_script(
  'build-aux/dist-vendor.sh',
  meson.project_build_root() / 'meson-dist' / meson.project_name() + '-' + meson.project_version(),
  meson.project_source_root()
 )
 subdir('src')
 subdir('data')
 gnome.post_install(
  gtk_update_icon_cache: true,
  update_desktop_database: true,
 )
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -0,0 +1,11 @@
 option(
  'profile',
  type: 'combo',
  choices: [
    'default',
    'development'
  ],
  value: 'default',
  description: 'The build profile for Helvum. One of "default" or "development".'
 )
--- a/screenshot.png
+++ b/screenshot.png
--- a/src/application.rs
+++ b/src/application.rs
@@ -0,0 +1,261 @@
 // application.rs
 //
 // Copyright 2021 Tom A. Wagner <tom.a.wagner@protonmail.com>
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // This program is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 // GNU General Public License for more details.
 //
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 //
 // SPDX-License-Identifier: GPL-3.0-only
 use std::cell::RefCell;
 use gtk::{
    gio,
    glib::{self, clone, Continue, Receiver},
    prelude::*,
    subclass::prelude::*,
 };
 use log::info;
 use pipewire::{channel::Sender, spa::Direction};
 use crate::{
    view::{self},
    GtkMessage, MediaType, NodeType, PipewireLink, PipewireMessage,
 };
 static STYLE: &str = include_str!("style.css");
 mod imp {
    use super::*;
    use once_cell::unsync::OnceCell;
    #[derive(Default)]
    pub struct Application {
        pub(super) graphview: view::GraphView,
        pub(super) pw_sender: OnceCell<RefCell<Sender<GtkMessage>>>,
    }
    #[glib::object_subclass]
    impl ObjectSubclass for Application {
        const NAME: &'static str = "HelvumApplication";
        type Type = super::Application;
        type ParentType = gtk::Application;
    }
    impl ObjectImpl for Application {}
    impl ApplicationImpl for Application {
        fn activate(&self, app: &Self::Type) {
            let scrollwindow = gtk::ScrolledWindow::builder()
                .child(&self.graphview)
                .build();
            let window = gtk::ApplicationWindow::builder()
                .application(app)
                .default_width(1280)
                .default_height(720)
                .title("Helvum - Pipewire Patchbay")
                .child(&scrollwindow)
                .build();
            window
                .settings()
                .set_gtk_application_prefer_dark_theme(true);
            window.show();
        }
        fn startup(&self, app: &Self::Type) {
            self.parent_startup(app);
            // Load CSS from the STYLE variable.
            let provider = gtk::CssProvider::new();
            provider.load_from_data(STYLE.as_bytes());
            gtk::StyleContext::add_provider_for_display(
                &gtk::gdk::Display::default().expect("Error initializing gtk css provider."),
                &provider,
                gtk::STYLE_PROVIDER_PRIORITY_APPLICATION,
            );
        }
    }
    impl GtkApplicationImpl for Application {}
 }
 glib::wrapper! {
    pub struct Application(ObjectSubclass<imp::Application>)
        @extends gio::Application, gtk::Application,
        @implements gio::ActionGroup, gio::ActionMap;
 }
 impl Application {
    /// Create the view.
    /// This will set up the entire user interface and prepare it for being run.
    pub(super) fn new(
        gtk_receiver: Receiver<PipewireMessage>,
        pw_sender: Sender<GtkMessage>,
    ) -> Self {
        let app: Application = glib::Object::new(&[("application-id", &"org.pipewire.Helvum")])
            .expect("Failed to create new Application");
        let imp = imp::Application::from_instance(&app);
        imp.pw_sender
            .set(RefCell::new(pw_sender))
            // Discard the returned sender, as it does not implement `Debug`.
            .map_err(|_| ())
            .expect("pw_sender field was already set");
        // Add <Control-Q> shortcut for quitting the application.
        let quit = gtk::gio::SimpleAction::new("quit", None);
        quit.connect_activate(clone!(@weak app => move |_, _| {
            app.quit();
        }));
        app.set_accels_for_action("app.quit", &["<Control>Q"]);
        app.add_action(&quit);
        // React to messages received from the pipewire thread.
        gtk_receiver.attach(
            None,
            clone!(
                @weak app => @default-return Continue(true),
                move |msg| {
                    match msg {
                        PipewireMessage::NodeAdded{ id, name, node_type } => app.add_node(id, name.as_str(), node_type),
                        PipewireMessage::PortAdded{ id, node_id, name, direction, media_type } => app.add_port(id, name.as_str(), node_id, direction, media_type),
                        PipewireMessage::LinkAdded{ id, node_from, port_from, node_to, port_to, active} => app.add_link(id, node_from, port_from, node_to, port_to, active),
                        PipewireMessage::LinkStateChanged { id, active } => app.link_state_changed(id, active), // TODO
                        PipewireMessage::NodeRemoved { id } => app.remove_node(id),
                        PipewireMessage::PortRemoved { id, node_id } => app.remove_port(id, node_id),
                        PipewireMessage::LinkRemoved { id } => app.remove_link(id)
                    };
                    Continue(true)
                }
            ),
        );
        app
    }
    /// Add a new node to the view.
    fn add_node(&self, id: u32, name: &str, node_type: Option<NodeType>) {
        info!("Adding node to graph: id {}", id);
        imp::Application::from_instance(self).graphview.add_node(
            id,
            view::Node::new(name),
            node_type,
        );
    }
    /// Add a new port to the view.
    fn add_port(
        &self,
        id: u32,
        name: &str,
        node_id: u32,
        direction: Direction,
        media_type: Option<MediaType>,
    ) {
        info!("Adding port to graph: id {}", id);
        let imp = imp::Application::from_instance(self);
        let port = view::Port::new(id, name, direction, media_type);
        // Create or delete a link if the widget emits the "port-toggled" signal.
        port.connect_local(
            "port_toggled",
            false,
            clone!(@weak self as app => @default-return None, move |args| {
                // Args always look like this: &[widget, id_port_from, id_port_to]
                let port_from = args[1].get::<u32>().unwrap();
                let port_to = args[2].get::<u32>().unwrap();
                app.toggle_link(port_from, port_to);
                None
            }),
        );
        imp.graphview.add_port(node_id, id, port);
    }
    /// Add a new link to the view.
    fn add_link(
        &self,
        id: u32,
        node_from: u32,
        port_from: u32,
        node_to: u32,
        port_to: u32,
        active: bool,
    ) {
        info!("Adding link to graph: id {}", id);
        // FIXME: Links should be colored depending on the data they carry (video, audio, midi) like ports are.
        // Update graph to contain the new link.
        imp::Application::from_instance(self).graphview.add_link(
            id,
            PipewireLink {
                node_from,
                port_from,
                node_to,
                port_to,
            },
            active,
        );
    }
    fn link_state_changed(&self, id: u32, active: bool) {
        info!(
            "Link state changed: Link (id={}) is now {}",
            id,
            if active { "active" } else { "inactive" }
        );
        imp::Application::from_instance(self)
            .graphview
            .set_link_state(id, active);
    }
    // Toggle a link between the two specified ports on the remote pipewire server.
    fn toggle_link(&self, port_from: u32, port_to: u32) {
        let imp = imp::Application::from_instance(self);
        let sender = imp.pw_sender.get().expect("pw_sender not set").borrow_mut();
        sender
            .send(GtkMessage::ToggleLink { port_from, port_to })
            .expect("Failed to send message");
    }
    /// Remove the node with the specified id from the view.
    fn remove_node(&self, id: u32) {
        info!("Removing node from graph: id {}", id);
        let imp = imp::Application::from_instance(self);
        imp.graphview.remove_node(id);
    }
    /// Remove the port with the id `id` from the node with the id `node_id`
    /// from the view.
    fn remove_port(&self, id: u32, node_id: u32) {
        info!("Removing port from graph: id {}, node_id: {}", id, node_id);
        let imp = imp::Application::from_instance(self);
        imp.graphview.remove_port(id, node_id);
    }
    /// Remove the link with the specified id from the view.
    fn remove_link(&self, id: u32) {
        info!("Removing link from graph: id {}", id);
        let imp = imp::Application::from_instance(self);
        imp.graphview.remove_link(id);
    }
 }
--- a/src/main.rs
+++ b/src/main.rs
@@ -1,12 +1,92 @@
 // main.rs
 //
 // Copyright 2021 Tom A. Wagner <tom.a.wagner@protonmail.com>
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // This program is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 // GNU General Public License for more details.
 //
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 //
 // SPDX-License-Identifier: GPL-3.0-only
 mod application;
 mod pipewire_connection;
 mod pipewire_state;
 mod view;
 use glib::PRIORITY_DEFAULT;
 use gtk::prelude::*;
 use pipewire::spa::Direction;
-use std::{cell::RefCell, rc::Rc};
+/// Messages sent by the GTK thread to notify the pipewire thread.
 #[derive(Debug, Clone)]
 enum GtkMessage {
    /// Toggle a link between the two specified ports.
    ToggleLink { port_from: u32, port_to: u32 },
    /// Quit the event loop and let the thread finish.
    Terminate,
 }
-#[derive(Debug)]
+/// Messages sent by the pipewire thread to notify the GTK thread.
 #[derive(Debug, Clone)]
 enum PipewireMessage {
    NodeAdded {
        id: u32,
        name: String,
        node_type: Option<NodeType>,
    },
    PortAdded {
        id: u32,
        node_id: u32,
        name: String,
        direction: Direction,
        media_type: Option<MediaType>,
    },
    LinkAdded {
        id: u32,
        node_from: u32,
        port_from: u32,
        node_to: u32,
        port_to: u32,
        active: bool,
    },
    LinkStateChanged {
        id: u32,
        active: bool,
    },
    NodeRemoved {
        id: u32,
    },
    PortRemoved {
        id: u32,
        node_id: u32,
    },
    LinkRemoved {
        id: u32,
    },
 }
 #[derive(Debug, Clone)]
 pub enum NodeType {
    Input,
    Output,
 }
 #[derive(Debug, Copy, Clone)]
 pub enum MediaType {
    Audio,
    Video,
    Midi,
 }
 #[derive(Debug, Clone)]
 pub struct PipewireLink {
    pub node_from: u32,
    pub port_from: u32,
@@ -14,46 +94,41 @@ pub struct PipewireLink {
    pub port_to: u32,
 }
 static GLIB_LOGGER: glib::GlibLogger = glib::GlibLogger::new(
    glib::GlibLoggerFormat::Structured,
    glib::GlibLoggerDomain::CrateTarget,
 );
 fn init_glib_logger() {
    log::set_logger(&GLIB_LOGGER).expect("Failed to set logger");
    // Glib does not have a "Trace" log level, so only print messages "Debug" or higher priority.
    log::set_max_level(log::LevelFilter::Debug);
 }
 fn main() -> Result<(), Box<dyn std::error::Error>> {
-    env_logger::init();
+    init_glib_logger();
    gtk::init()?;
-    let graphview = Rc::new(RefCell::new(view::GraphView::new()));
+    // Aquire main context so that we can attach the gtk channel later.
    let ctx = glib::MainContext::default();
    let _guard = ctx.acquire().unwrap();
-    // Create the connection to the pipewire server and do an initial roundtrip before showing the view,
+    // Start the pipewire thread with channels in both directions.
-    // so that the graph is already populated when the window opens.
+    let (gtk_sender, gtk_receiver) = glib::MainContext::channel(PRIORITY_DEFAULT);
-    let pw_con = pipewire_connection::PipewireConnection::new(pipewire_state::PipewireState::new(
+    let (pw_sender, pw_receiver) = pipewire::channel::channel();
-        graphview.clone(),
+    let pw_thread =
-    ))
+        std::thread::spawn(move || pipewire_connection::thread_main(gtk_sender, pw_receiver));
    .expect("Failed to initialize pipewire connection");
    pw_con.roundtrip();
    // From now on, call roundtrip() every second.
    gtk::glib::timeout_add_seconds_local(1, move || {
        pw_con.roundtrip();
        Continue(true)
    });
-    let app = gtk::Application::new(Some("org.freedesktop.pipewire.graphui"), Default::default())
+    let app = application::Application::new(gtk_receiver, pw_sender.clone());
        .expect("Application creation failed");
-    app.connect_activate(move |app| {
+    app.run();
        let scrollwindow = gtk::ScrolledWindowBuilder::new()
            .child(&*graphview.borrow())
            .build();
        let window = gtk::ApplicationWindowBuilder::new()
            .application(app)
            .default_width(1280)
            .default_height(720)
            .title("Pipewire Graph Editor")
            .child(&scrollwindow)
            .build();
        window
            .get_settings()
            .set_property_gtk_application_prefer_dark_theme(true);
        window.show();
    });
-    app.run(&std::env::args().collect::<Vec<_>>());
+    pw_sender
        .send(GtkMessage::Terminate)
        .expect("Failed to send message");
    pw_thread.join().expect("Pipewire thread panicked");
    Ok(())
 }
--- a/src/meson.build
+++ b/src/meson.build
@@ -0,0 +1,31 @@
 cargo_options = [ '--manifest-path', meson.project_source_root() / 'Cargo.toml' ]
 cargo_options += [ '--target-dir', meson.project_build_root() / 'src' ]
 if get_option('profile') == 'default'
  cargo_options += [ '--release' ]
  rust_target = 'release'
  message('Building in release mode')
 else
  rust_target = 'debug'
  message('Building in debug mode')
 endif
 cargo_env = [ 'CARGO_HOME=' + meson.project_build_root() / 'cargo-home' ]
 custom_target(
  'cargo-build',
  build_by_default: true,
  build_always_stale: true,
  output: meson.project_name(),
  console: true,
  install: true,
  install_dir: bindir,
  command: [
    'env',
    cargo_env,
    cargo, 'build',
    cargo_options,
    '&&',
    'cp', 'src' / rust_target / meson.project_name(), '@OUTPUT@',
  ],
 )
--- a/src/pipewire_connection.rs
+++ b/src/pipewire_connection.rs
@@ -1,84 +1,321 @@
-use crate::pipewire_state::PipewireState;
+// pipewire_connection.rs
 //
 // Copyright 2021 Tom A. Wagner <tom.a.wagner@protonmail.com>
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // This program is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 // GNU General Public License for more details.
 //
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 //
 // SPDX-License-Identifier: GPL-3.0-only
 mod state;
 use std::{cell::RefCell, collections::HashMap, rc::Rc};
 use gtk::glib::{self, clone};
-use pipewire as pw;
+use log::{debug, info, warn};
-
+use pipewire::{
-use std::{
+    link::{Link, LinkChangeMask, LinkListener, LinkState},
-    cell::{Cell, RefCell},
+    prelude::*,
-    rc::Rc,
+    properties,
    registry::{GlobalObject, Registry},
    spa::{Direction, ForeignDict},
    types::ObjectType,
    Context, Core, MainLoop,
 };
-/// This struct is responsible for communication with the pipewire server.
+use crate::{GtkMessage, MediaType, NodeType, PipewireMessage};
-/// It handles new globals appearing as well as globals being removed.
+use state::{Item, State};
-///
+
-/// It's `roundtrip` function must be called regularly to receive updates.
+enum ProxyItem {
-pub struct PipewireConnection {
+    Link {
-    mainloop: pw::MainLoop,
+        _proxy: Link,
-    _context: pw::Context<pw::MainLoop>,
+        _listener: LinkListener,
-    core: Rc<pw::Core>,
+    },
    _registry: pw::registry::Registry,
    _listeners: pw::registry::Listener,
    _state: Rc<RefCell<PipewireState>>,
 }
-impl PipewireConnection {
+/// The "main" function of the pipewire thread.
-    pub fn new(state: PipewireState) -> Result<Self, String> {
+pub(super) fn thread_main(
-        // Initialize pipewire lib and obtain needed pipewire objects.
+    gtk_sender: glib::Sender<PipewireMessage>,
-        pw::init();
+    pw_receiver: pipewire::channel::Receiver<GtkMessage>,
-        let mainloop = pw::MainLoop::new().map_err(|_| "Failed to create pipewire mainloop!")?;
+) {
-        let context =
+    let mainloop = MainLoop::new().expect("Failed to create mainloop");
-            pw::Context::new(&mainloop).map_err(|_| "Failed to create pipewire context")?;
+    let context = Context::new(&mainloop).expect("Failed to create context");
-        let core = Rc::new(
+    let core = Rc::new(context.connect(None).expect("Failed to connect to remote"));
-            context
+    let registry = Rc::new(core.get_registry().expect("Failed to get registry"));
-                .connect()
+
-                .map_err(|_| "Failed to connect to pipewire core")?,
+    // Keep proxies and their listeners alive so that we can receive info events.
    let proxies = Rc::new(RefCell::new(HashMap::new()));
    let state = Rc::new(RefCell::new(State::new()));
    let _receiver = pw_receiver.attach(&mainloop, {
        clone!(@strong mainloop, @weak core, @weak registry, @strong state => move |msg| match msg {
            GtkMessage::ToggleLink { port_from, port_to } => toggle_link(port_from, port_to, &core, &registry, &state),
            GtkMessage::Terminate => mainloop.quit(),
        })
    });
    let _listener = registry
        .add_listener_local()
        .global(clone!(@strong gtk_sender, @weak registry, @strong proxies, @strong state =>
            move |global| match global.type_ {
                ObjectType::Node => handle_node(global, &gtk_sender, &state),
                ObjectType::Port => handle_port(global, &gtk_sender, &state),
                ObjectType::Link => handle_link(global, &gtk_sender, &registry, &proxies, &state),
                _ => {
                    // Other objects are not interesting to us
                }
            }
        ))
        .global_remove(clone!(@strong proxies, @strong state => move |id| {
            if let Some(item) = state.borrow_mut().remove(id) {
                gtk_sender.send(match item {
                    Item::Node { .. } => PipewireMessage::NodeRemoved {id},
                    Item::Port { node_id } => PipewireMessage::PortRemoved {id, node_id},
                    Item::Link { .. } => PipewireMessage::LinkRemoved {id},
                }).expect("Failed to send message");
            } else {
                warn!(
                    "Attempted to remove item with id {} that is not saved in state",
                    id
                );
-        let registry = core.get_registry();
+            }
-        let state = Rc::new(RefCell::new(state));
+            proxies.borrow_mut().remove(&id);
        // Notify state on globals added / removed
        let _listeners = registry
            .add_listener_local()
            .global(clone!(@weak state => @default-panic, move |global| {
                state.borrow_mut().global(global);
            }))
            .global_remove(clone!(@weak state => @default-panic, move |id| {
                state.borrow_mut().global_remove(id);
        }))
        .register();
-        Ok(Self {
+    mainloop.run();
-            mainloop: mainloop,
+}
-            _context: context,
+
-            core,
+/// Handle a new node being added
-            _registry: registry,
+fn handle_node(
-            _listeners,
+    node: &GlobalObject<ForeignDict>,
-            _state: state,
+    sender: &glib::Sender<PipewireMessage>,
-        })
+    state: &Rc<RefCell<State>>,
 ) {
    let props = node
        .props
        .as_ref()
        .expect("Node object is missing properties");
    // Get the nicest possible name for the node, using a fallback chain of possible name attributes.
    let name = String::from(
        props
            .get("node.nick")
            .or_else(|| props.get("node.description"))
            .or_else(|| props.get("node.name"))
            .unwrap_or_default(),
    );
    // FIXME: Instead of checking these props, the "EnumFormat" parameter should be checked instead.
    let media_type = props.get("media.class").and_then(|class| {
        if class.contains("Audio") {
            Some(MediaType::Audio)
        } else if class.contains("Video") {
            Some(MediaType::Video)
        } else if class.contains("Midi") {
            Some(MediaType::Midi)
        } else {
            None
        }
    });
-    /// Receive all events from the pipewire server, sending them to the `pipewire_state` struct for processing.
+    let media_class = |class: &str| {
-    pub fn roundtrip(&self) {
+        if class.contains("Sink") || class.contains("Input") {
-        let done = Rc::new(Cell::new(false));
+            Some(NodeType::Input)
-        let pending = self.core.sync(0);
+        } else if class.contains("Source") || class.contains("Output") {
            Some(NodeType::Output)
        } else {
            None
        }
    };
-        let done_clone = done.clone();
+    let node_type = props
-        let loop_clone = self.mainloop.clone();
+        .get("media.category")
        .and_then(|class| {
            if class.contains("Duplex") {
                None
            } else {
                props.get("media.class").and_then(media_class)
            }
        })
        .or_else(|| props.get("media.class").and_then(media_class));
-        let _listener = self
+    state.borrow_mut().insert(
-            .core
+        node.id,
        Item::Node {
            // widget: node_widget,
            media_type,
        },
    );
    sender
        .send(PipewireMessage::NodeAdded {
            id: node.id,
            name,
            node_type,
        })
        .expect("Failed to send message");
 }
 /// Handle a new port being added
 fn handle_port(
    port: &GlobalObject<ForeignDict>,
    sender: &glib::Sender<PipewireMessage>,
    state: &Rc<RefCell<State>>,
 ) {
    let props = port
        .props
        .as_ref()
        .expect("Port object is missing properties");
    let name = props.get("port.name").unwrap_or_default().to_string();
    let node_id: u32 = props
        .get("node.id")
        .expect("Port has no node.id property!")
        .parse()
        .expect("Could not parse node.id property");
    let direction = if matches!(props.get("port.direction"), Some("in")) {
        Direction::Input
    } else {
        Direction::Output
    };
    // Find out the nodes media type so that the port can be colored.
    let media_type = if let Some(Item::Node { media_type, .. }) = state.borrow().get(node_id) {
        media_type.to_owned()
    } else {
        warn!("Node not found for Port {}", port.id);
        None
    };
    // Save node_id so we can delete this port easily.
    state.borrow_mut().insert(port.id, Item::Port { node_id });
    sender
        .send(PipewireMessage::PortAdded {
            id: port.id,
            node_id,
            name,
            direction,
            media_type,
        })
        .expect("Failed to send message");
 }
 /// Handle a new link being added
 fn handle_link(
    link: &GlobalObject<ForeignDict>,
    sender: &glib::Sender<PipewireMessage>,
    registry: &Rc<Registry>,
    proxies: &Rc<RefCell<HashMap<u32, ProxyItem>>>,
    state: &Rc<RefCell<State>>,
 ) {
    debug!(
        "New link (id:{}) appeared, setting up info listener.",
        link.id
    );
    let proxy: Link = registry.bind(link).expect("Failed to bind to link proxy");
    let listener = proxy
        .add_listener_local()
-            .done(move |id, seq| {
+        .info(clone!(@strong state, @strong sender => move |info| {
-                if id == pw::PW_ID_CORE && seq == pending {
+            debug!("Received link info: {:?}", info);
-                    done_clone.set(true);
+
-                    loop_clone.quit();
+            let id = info.id();
            let mut state = state.borrow_mut();
            if let Some(Item::Link { .. }) = state.get(id) {
                // Info was an update - figure out if we should notify the gtk thread
                if info.change_mask().contains(LinkChangeMask::STATE) {
                    sender.send(PipewireMessage::LinkStateChanged {
                        id,
                        active: matches!(info.state(), LinkState::Active)
                    }).expect("Failed to send message");
                }
-            })
+                // TODO -- check other values that might have changed
            } else {
                // First time we get info. We can now notify the gtk thread of a new link.
                let node_from = info.output_node_id();
                let port_from = info.output_port_id();
                let node_to = info.input_node_id();
                let port_to = info.input_port_id();
                state.insert(id, Item::Link {
                    port_from, port_to
                });
                sender.send(PipewireMessage::LinkAdded {
                    id,
                    node_from,
                    port_from,
                    node_to,
                    port_to,
                    active: matches!(info.state(), LinkState::Active)
                }).expect(
                    "Failed to send message"
                );
            }
        }))
        .register();
-        while !done.get() {
+    proxies.borrow_mut().insert(
-            self.mainloop.run();
+        link.id,
        ProxyItem::Link {
            _proxy: proxy,
            _listener: listener,
        },
    );
 }
 /// Toggle a link between the two specified ports.
 fn toggle_link(
    port_from: u32,
    port_to: u32,
    core: &Rc<Core>,
    registry: &Rc<Registry>,
    state: &Rc<RefCell<State>>,
 ) {
    let state = state.borrow_mut();
    if let Some(id) = state.get_link_id(port_from, port_to) {
        info!("Requesting removal of link with id {}", id);
        // FIXME: Handle error
        registry.destroy_global(id);
    } else {
        info!(
            "Requesting creation of link from port id:{} to port id:{}",
            port_from, port_to
        );
        let node_from = state
            .get_node_of_port(port_from)
            .expect("Requested port not in state");
        let node_to = state
            .get_node_of_port(port_to)
            .expect("Requested port not in state");
        if let Err(e) = core.create_object::<Link, _>(
            "link-factory",
            &properties! {
                "link.output.node" => node_from.to_string(),
                "link.output.port" => port_from.to_string(),
                "link.input.node" => node_to.to_string(),
                "link.input.port" => port_to.to_string(),
                "object.linger" => "1"
            },
        ) {
            warn!("Failed to create link: {}", e);
        }
    }
 }
--- a/src/pipewire_connection/state.rs
+++ b/src/pipewire_connection/state.rs
@@ -0,0 +1,100 @@
 // state.rs
 //
 // Copyright 2021 Tom A. Wagner <tom.a.wagner@protonmail.com>
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // This program is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 // GNU General Public License for more details.
 //
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 //
 // SPDX-License-Identifier: GPL-3.0-only
 use std::collections::HashMap;
 use crate::MediaType;
 /// Any pipewire item we need to keep track of.
 /// These will be saved in the `State` struct associated with their id.
 pub(super) enum Item {
    Node {
        // Keep track of the nodes media type to color ports on it.
        media_type: Option<MediaType>,
    },
    Port {
        // Save the id of the node this is on so we can remove the port from it
        // when it is deleted.
        node_id: u32,
    },
    Link {
        port_from: u32,
        port_to: u32,
    },
 }
 /// This struct keeps track of any relevant items and stores them under their IDs.
 ///
 /// Given two port ids, it can also efficiently find the id of the link that connects them.
 #[derive(Default)]
 pub(super) struct State {
    /// Map pipewire ids to items.
    items: HashMap<u32, Item>,
    /// Map `(output port id, input port id)` tuples to the id of the link that connects them.
    links: HashMap<(u32, u32), u32>,
 }
 impl State {
    /// Create a new, empty state.
    pub fn new() -> Self {
        Self::default()
    }
    /// Add a new item under the specified id.
    pub fn insert(&mut self, id: u32, item: Item) {
        if let Item::Link {
            port_from, port_to, ..
        } = item
        {
            self.links.insert((port_from, port_to), id);
        }
        self.items.insert(id, item);
    }
    /// Get the item that has the specified id.
    pub fn get(&self, id: u32) -> Option<&Item> {
        self.items.get(&id)
    }
    /// Get the id of the link that links the two specified ports.
    pub fn get_link_id(&self, output_port: u32, input_port: u32) -> Option<u32> {
        self.links.get(&(output_port, input_port)).copied()
    }
    /// Remove the item with the specified id, returning it if it exists.
    pub fn remove(&mut self, id: u32) -> Option<Item> {
        let removed = self.items.remove(&id);
        if let Some(Item::Link { port_from, port_to }) = removed {
            self.links.remove(&(port_from, port_to));
        }
        removed
    }
    /// Convenience function: Get the id of the node a port is on
    pub fn get_node_of_port(&self, port: u32) -> Option<u32> {
        if let Some(Item::Port { node_id }) = self.get(port) {
            Some(*node_id)
        } else {
            None
        }
    }
 }
--- a/src/pipewire_state.rs
+++ b/src/pipewire_state.rs
@@ -1,168 +0,0 @@
 use crate::{view, PipewireLink};
 use pipewire::{
    port::Direction,
    registry::{GlobalObject, ObjectType},
 };
 use std::{cell::RefCell, collections::HashMap, rc::Rc};
 enum Item {
    Node(view::Node),
    Port { node_id: u32 },
    Link,
 }
 /// This struct stores the state of the pipewire graph.
 ///
 /// It receives updates from the [`PipewireConnection`](crate::pipewire_connection::PipewireConnection)
 /// responsible for updating it and applies them to its internal state.
 ///
 /// It also keeps the view updated to always reflect this internal state.
 pub struct PipewireState {
    graphview: Rc<RefCell<view::GraphView>>,
    items: HashMap<u32, Item>,
 }
 impl PipewireState {
    pub fn new(graphview: Rc<RefCell<view::GraphView>>) -> Self {
        let result = Self {
            graphview,
            items: HashMap::new(),
        };
        result
    }
    /// This function is called from the `PipewireConnection` struct responsible for updating this struct.
    pub fn global(&mut self, global: GlobalObject) {
        match global.type_ {
            ObjectType::Node => {
                self.add_node(global);
            }
            ObjectType::Port => {
                self.add_port(global);
            }
            ObjectType::Link => {
                self.add_link(global);
            }
            _ => {}
        }
    }
    fn add_node(&mut self, node: GlobalObject) {
        // Update graph to contain the new node.
        let node_widget = crate::view::Node::new(&format!(
            "{}",
            node.props
                .map(|dict| String::from(
                    dict.get("node.nick")
                        .or(dict.get("node.description"))
                        .or(dict.get("node.name"))
                        .unwrap_or_default()
                ))
                .unwrap_or_default()
        ));
        self.graphview
            .borrow_mut()
            .add_node(node.id, node_widget.clone());
        // Save the created widget so we can delete ports easier.
        self.items.insert(node.id, Item::Node(node_widget));
    }
    fn add_port(&mut self, port: GlobalObject) {
        // Update graph to contain the new port.
        let props = port.props.expect("Port object is missing properties");
        let port_label = format!("{}", props.get("port.name").unwrap_or_default());
        let node_id: u32 = props
            .get("node.id")
            .expect("Port has no node.id property!")
            .parse()
            .expect("Could not parse node.id property");
        let new_port = crate::view::port::Port::new(
            port.id,
            &port_label,
            if matches!(props.get("port.direction"), Some("in")) {
                Direction::Input
            } else {
                Direction::Output
            },
        );
        self.graphview
            .borrow_mut()
            .add_port_to_node(node_id, new_port.id, new_port);
        // Save node_id so we can delete this port easily.
        self.items.insert(port.id, Item::Port { node_id });
    }
    fn add_link(&mut self, link: GlobalObject) {
        self.items.insert(link.id, Item::Link);
        // Update graph to contain the new link.
        let props = link.props.expect("Link object is missing properties");
        let input_node: u32 = props
            .get("link.input.node")
            .expect("Link has no link.input.node property")
            .parse()
            .expect("Could not parse link.input.node property");
        let input_port: u32 = props
            .get("link.input.port")
            .expect("Link has no link.input.port property")
            .parse()
            .expect("Could not parse link.input.port property");
        let output_node: u32 = props
            .get("link.output.node")
            .expect("Link has no link.input.node property")
            .parse()
            .expect("Could not parse link.input.node property");
        let output_port: u32 = props
            .get("link.output.port")
            .expect("Link has no link.output.port property")
            .parse()
            .expect("Could not parse link.output.port property");
        self.graphview.borrow_mut().add_link(
            link.id,
            PipewireLink {
                node_from: output_node,
                port_from: output_port,
                node_to: input_node,
                port_to: input_port,
            },
        );
    }
    /// This function is called from the `PipewireConnection` struct responsible for updating this struct.
    pub fn global_remove(&mut self, id: u32) {
        if let Some(item) = self.items.get(&id) {
            match item {
                Item::Node(_) => self.remove_node(id),
                Item::Port { node_id } => self.remove_port(id, *node_id),
                Item::Link => self.remove_link(id),
            }
            self.items.remove(&id);
        } else {
            log::warn!(
                "Attempted to remove item with id {} that is not saved in state",
                id
            );
        }
    }
    fn remove_node(&self, id: u32) {
        self.graphview.borrow().remove_node(id);
    }
    fn remove_port(&self, id: u32, node_id: u32) {
        if let Some(Item::Node(node)) = self.items.get(&node_id) {
            node.remove_port(id);
        }
    }
    fn remove_link(&self, id: u32) {
        self.graphview.borrow().remove_link(id);
    }
 }
--- a/src/style.css
+++ b/src/style.css
@@ -0,0 +1,23 @@
@define-color audio rgb(50,100,240);
@define-color video rgb(200,200,0);
@define-color midi rgb(200,0,50);
@define-color graphview-link #808080;
 .audio {
    background: @audio;
    color: black;
 }
 .video {
    background: @video;
    color: black;
 }
 .midi {
    background: @midi;
    color: black;
 }
 graphview {
    background: @text_view_bg;
 }
--- a/src/view/graph_view.rs
+++ b/src/view/graph_view.rs
@@ -1,42 +1,60 @@
-use super::Node;
+// graph_view.rs
 //
 // Copyright 2021 Tom A. Wagner <tom.a.wagner@protonmail.com>
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // This program is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 // GNU General Public License for more details.
 //
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 //
 // SPDX-License-Identifier: GPL-3.0-only
-use gtk::{glib, graphene, gsk, prelude::*, subclass::prelude::*, WidgetExt};
+use super::{Node, Port};
-use std::collections::HashMap;
+use gtk::{
    glib::{self, clone},
    graphene, gsk,
    prelude::*,
    subclass::prelude::*,
 };
 use log::{error, warn};
 use std::{cmp::Ordering, collections::HashMap};
 use crate::NodeType;
 mod imp {
    use super::*;
    use gtk::{gdk, WidgetExt};
    use std::{cell::RefCell, rc::Rc};
    use log::warn;
    #[derive(Default)]
    pub struct GraphView {
        pub(super) nodes: RefCell<HashMap<u32, Node>>,
-        pub(super) links: RefCell<HashMap<u32, crate::PipewireLink>>,
+        /// Stores the link and whether it is currently active.
-        pub(super) dragged: Rc<RefCell<Option<gtk::Widget>>>,
+        pub(super) links: RefCell<HashMap<u32, (crate::PipewireLink, bool)>>,
    }
    #[glib::object_subclass]
    impl ObjectSubclass for GraphView {
        const NAME: &'static str = "GraphView";
        type Type = super::GraphView;
        type ParentType = gtk::Widget;
        type Instance = glib::subclass::simple::InstanceStruct<Self>;
        type Class = glib::subclass::simple::ClassStruct<Self>;
        glib::object_subclass!();
        fn class_init(klass: &mut Self::Class) {
            // The layout manager determines how child widgets are laid out.
            klass.set_layout_manager_type::<gtk::FixedLayout>();
-        }
+            klass.set_css_name("graphview");
        fn new() -> Self {
            Self {
                nodes: RefCell::new(HashMap::new()),
                links: RefCell::new(HashMap::new()),
                dragged: Rc::new(RefCell::new(None)),
            }
        }
    }
@@ -44,28 +62,46 @@ mod imp {
        fn constructed(&self, obj: &Self::Type) {
            self.parent_constructed(obj);
-            // Move the Node that is currently being dragged to the cursor position as long as Mouse Button 1 is held.
+            let drag_state = Rc::new(RefCell::new(None));
-            let motion_controller = gtk::EventControllerMotion::new();
+            let drag_controller = gtk::GestureDrag::new();
            motion_controller.connect_motion(|controller, x, y| {
                let instance = controller
                    .get_widget()
                    .unwrap()
                    .dynamic_cast::<Self::Type>()
                    .unwrap();
                let this = imp::GraphView::from_instance(&instance);
-                if let Some(ref widget) = *this.dragged.borrow() {
+            drag_controller.connect_drag_begin(
-                    if controller
+                clone!(@strong drag_state => move |drag_controller, x, y| {
-                        .get_current_event()
+                    let mut drag_state = drag_state.borrow_mut();
-                        .unwrap()
+                    let widget = drag_controller
-                        .get_modifier_state()
+                        .widget()
-                        .contains(gdk::ModifierType::BUTTON1_MASK)
+                        .dynamic_cast::<Self::Type>()
-                    {
+                        .expect("drag-begin event is not on the GraphView");
-                        instance.move_node(&widget, x as f32, y as f32);
+                    // pick() should at least return the widget itself.
                    let target = widget.pick(x, y, gtk::PickFlags::DEFAULT).expect("drag-begin pick() did not return a widget");
                    *drag_state = if target.ancestor(Port::static_type()).is_some() {
                        // The user targeted a port, so the dragging should be handled by the Port
                        // component instead of here.
                        None
                    } else if let Some(target) = target.ancestor(Node::static_type()) {
                        // The user targeted a Node without targeting a specific Port.
                        // Drag the Node around the screen.
                        let (x, y) = widget.get_node_position(&target);
                        Some((target, x, y))
                    } else {
                        None
                    }
-                };
+                }
-            });
+            ));
-            obj.add_controller(&motion_controller);
+            drag_controller.connect_drag_update(
                clone!(@strong drag_state => move |drag_controller, x, y| {
                    let widget = drag_controller
                        .widget()
                        .dynamic_cast::<Self::Type>()
                        .expect("drag-update event is not on the GraphView");
                    let drag_state = drag_state.borrow();
                    if let Some((ref node, x1, y1)) = *drag_state {
                        widget.move_node(node, x1 + x as f32, y1 + y as f32);
                    }
                }
                ),
            );
            obj.add_controller(&drag_controller);
        }
        fn dispose(&self, _obj: &Self::Type) {
@@ -81,58 +117,99 @@ mod imp {
            /* FIXME: A lot of hardcoded values in here.
            Try to use relative units (em) and colours from the theme as much as possible. */
-            let alloc = widget.get_allocation();
+            let alloc = widget.allocation();
            let widget_bounds =
                graphene::Rect::new(0.0, 0.0, alloc.width() as f32, alloc.height() as f32);
-            let cr = snapshot
+            let background_cr = snapshot.append_cairo(&widget_bounds);
                .append_cairo(&graphene::Rect::new(
                    0.0,
                    0.0,
                    alloc.width as f32,
                    alloc.height as f32,
                ))
                .expect("Failed to get cairo context");
            // Try to replace the background color with a darker one from the theme.
            if let Some(rgba) = widget.get_style_context().lookup_color("text_view_bg") {
                cr.set_source_rgb(rgba.red.into(), rgba.green.into(), rgba.blue.into());
                cr.paint();
            } // TODO: else log colour not found
            // Draw a nice grid on the background.
-            cr.set_source_rgb(0.18, 0.18, 0.18);
+            background_cr.set_source_rgb(0.18, 0.18, 0.18);
-            cr.set_line_width(0.2); // TODO: Set to 1px
+            background_cr.set_line_width(0.2); // TODO: Set to 1px
            let mut y = 0.0;
-            while y < alloc.height.into() {
+            while y < alloc.height().into() {
-                cr.move_to(0.0, y);
+                background_cr.move_to(0.0, y);
-                cr.line_to(alloc.width as f64, y);
+                background_cr.line_to(alloc.width().into(), y);
                y += 20.0; // TODO: Change to em;
            }
            let mut x = 0.0;
-            while x < alloc.width as f64 {
+            while x < alloc.width().into() {
-                cr.move_to(x, 0.0);
+                background_cr.move_to(x, 0.0);
-                cr.line_to(x, alloc.height as f64);
+                background_cr.line_to(x, alloc.height().into());
                x += 20.0; // TODO: Change to em;
            }
-            cr.stroke();
+            if let Err(e) = background_cr.stroke() {
-
+                warn!("Failed to draw graphview grid: {}", e);
-            // Draw all links
+            };
            cr.set_line_width(2.0);
            cr.set_source_rgb(0.0, 0.0, 0.0);
            for link in self.links.borrow().values() {
                if let Some((from_x, from_y, to_x, to_y)) = self.get_link_coordinates(link) {
                    cr.move_to(from_x, from_y);
                    cr.curve_to(from_x + 75.0, from_y, to_x - 75.0, to_y, to_x, to_y);
                    cr.stroke();
                } else {
                    log::warn!("Could not get allocation of ports of link: {:?}", link);
                }
            }
            // Draw all children
            self.nodes
                .borrow()
                .values()
-                .for_each(|node| self.get_instance().snapshot_child(node, snapshot));
+                .for_each(|node| self.instance().snapshot_child(node, snapshot));
            // Draw all links
            let link_cr = snapshot.append_cairo(&graphene::Rect::new(
                0.0,
                0.0,
                alloc.width() as f32,
                alloc.height() as f32,
            ));
            link_cr.set_line_width(2.0);
            let rgba = widget
                .style_context()
                .lookup_color("graphview-link")
                .unwrap_or_else(|| gtk::gdk::RGBA::new(0.0, 0.0, 0.0, 0.0));
            link_cr.set_source_rgba(
                rgba.red().into(),
                rgba.green().into(),
                rgba.blue().into(),
                rgba.alpha().into(),
            );
            for (link, active) in self.links.borrow().values() {
                if let Some((from_x, from_y, to_x, to_y)) = self.get_link_coordinates(link) {
                    link_cr.move_to(from_x, from_y);
                    // Use dashed line for inactive links, full line otherwise.
                    if *active {
                        link_cr.set_dash(&[], 0.0);
                    } else {
                        link_cr.set_dash(&[10.0, 5.0], 0.0);
                    }
                    // If the output port is farther right than the input port and they have
                    // a similar y coordinate, apply a y offset to the control points
                    // so that the curve sticks out a bit.
                    let y_control_offset = if from_x > to_x {
                        f64::max(0.0, 25.0 - (from_y - to_y).abs())
                    } else {
                        0.0
                    };
                    // Place curve control offset by half the x distance between the two points.
                    // This makes the curve scale well for varying distances between the two ports,
                    // especially when the output port is farther right than the input port.
                    let half_x_dist = f64::abs(from_x - to_x) / 2.0;
                    link_cr.curve_to(
                        from_x + half_x_dist,
                        from_y - y_control_offset,
                        to_x - half_x_dist,
                        to_y - y_control_offset,
                        to_x,
                        to_y,
                    );
                    if let Err(e) = link_cr.stroke() {
                        warn!("Failed to draw graphview links: {}", e);
                    };
                } else {
                    warn!("Could not get allocation of ports of link: {:?}", link);
                }
            }
        }
    }
@@ -140,42 +217,34 @@ mod imp {
        /// Get coordinates for the drawn link to start at and to end at.
        ///
        /// # Returns
-        /// Some((from_x, from_y, to_x, to_y)) if all objects the links refers to exist as widgets.
+        /// `Some((from_x, from_y, to_x, to_y))` if all objects the links refers to exist as widgets.
        fn get_link_coordinates(&self, link: &crate::PipewireLink) -> Option<(f64, f64, f64, f64)> {
            let nodes = self.nodes.borrow();
            // For some reason, gtk4::WidgetExt::translate_coordinates gives me incorrect values,
            // so we manually calculate the needed offsets here.
-            let from_port = &nodes.get(&link.node_from)?.get_port(link.port_from)?.widget;
+            let from_port = &nodes.get(&link.node_from)?.get_port(link.port_from)?;
            let gtk::Allocation {
                x: mut fx,
                y: mut fy,
                width: fw,
                height: fh,
            } = from_port.get_allocation();
            let from_node = from_port
-                .get_ancestor(Node::static_type())
+                .ancestor(Node::static_type())
                .expect("Port is not a child of a node");
-            let gtk::Allocation { x: fnx, y: fny, .. } = from_node.get_allocation();
+            let from_x = from_node.allocation().x()
-            fx += fnx + fw;
+                + from_port.allocation().x()
-            fy += fny + (fh / 2);
+                + from_port.allocation().width();
            let from_y = from_node.allocation().y()
                + from_port.allocation().y()
                + (from_port.allocation().height() / 2);
-            let to_port = &nodes.get(&link.node_to)?.get_port(link.port_to)?.widget;
+            let to_port = &nodes.get(&link.node_to)?.get_port(link.port_to)?;
            let gtk::Allocation {
                x: mut tx,
                y: mut ty,
                height: th,
                ..
            } = to_port.get_allocation();
            let to_node = to_port
-                .get_ancestor(Node::static_type())
+                .ancestor(Node::static_type())
                .expect("Port is not a child of a node");
-            let gtk::Allocation { x: tnx, y: tny, .. } = to_node.get_allocation();
+            let to_x = to_node.allocation().x() + to_port.allocation().x();
-            tx += tnx;
+            let to_y = to_node.allocation().y()
-            ty += tny + (th / 2);
+                + to_port.allocation().y()
                + (to_port.allocation().height() / 2);
-            Some((fx as f64, fy as f64, tx as f64, ty as f64))
+            Some((from_x.into(), from_y.into(), to_x.into(), to_y.into()))
        }
    }
 }
@@ -190,14 +259,37 @@ impl GraphView {
        glib::Object::new(&[]).expect("Failed to create GraphView")
    }
-    pub fn add_node(&self, id: u32, node: Node) {
+    pub fn add_node(&self, id: u32, node: Node, node_type: Option<NodeType>) {
        let private = imp::GraphView::from_instance(self);
        node.set_parent(self);
-        // Place widgets in colums of 4, growing down, then right.
+        // Place widgets in colums of 3, growing down
-        // TODO: Make a better positioning algorithm.
+        let x = if let Some(node_type) = node_type {
-        let x = (private.nodes.borrow().len() / 4) as f32 * 400.0; // This relies on integer division rounding down.
+            match node_type {
-        let y = private.nodes.borrow().len() as f32 % 4.0 * 100.0;
+                NodeType::Output => 20.0,
                NodeType::Input => 820.0,
            }
        } else {
            420.0
        };
        let y = private
            .nodes
            .borrow()
            .values()
            .map(|node| {
                // Map nodes to their locations
                self.get_node_position(&node.clone().upcast())
            })
            .filter(|(x2, _)| {
                // Only look for other nodes that have a similar x coordinate
                (x - x2).abs() < 50.0
            })
            .max_by(|y1, y2| {
                // Get max in column
                y1.partial_cmp(y2).unwrap_or(Ordering::Equal)
            })
            .map_or(20_f32, |(_x, y)| y + 100.0);
        self.move_node(&node.clone().upcast(), x, y);
@@ -209,34 +301,48 @@ impl GraphView {
        let mut nodes = private.nodes.borrow_mut();
        if let Some(node) = nodes.remove(&id) {
            node.unparent();
        } else {
            warn!("Tried to remove non-existant node (id={}) from graph", id);
        }
    }
-    pub fn add_port_to_node(&self, node_id: u32, port_id: u32, port: crate::view::port::Port) {
+    pub fn add_port(&self, node_id: u32, port_id: u32, port: crate::view::port::Port) {
        let private = imp::GraphView::from_instance(self);
        if let Some(node) = private.nodes.borrow_mut().get_mut(&node_id) {
            node.add_port(port_id, port);
        } else {
-            // FIXME: Log this instead
+            error!(
            log::error!(
                "Node with id {} not found when trying to add port with id {} to graph",
-                node_id,
+                node_id, port_id
                port_id
            );
        }
    }
-    /// Add a link to the graph.
+    pub fn remove_port(&self, id: u32, node_id: u32) {
    ///
    /// `add_link` takes three arguments: `link_id` is the id of the link as assigned by the pipewire server,
    /// `from` and `to` are the id's of the ingoing and outgoing port, respectively.
    pub fn add_link(&self, link_id: u32, link: crate::PipewireLink) {
        let private = imp::GraphView::from_instance(self);
-        private.links.borrow_mut().insert(link_id, link);
+        let nodes = private.nodes.borrow();
        if let Some(node) = nodes.get(&node_id) {
            node.remove_port(id);
        }
    }
    pub fn add_link(&self, link_id: u32, link: crate::PipewireLink, active: bool) {
        let private = imp::GraphView::from_instance(self);
        private.links.borrow_mut().insert(link_id, (link, active));
        self.queue_draw();
    }
    pub fn set_link_state(&self, link_id: u32, active: bool) {
        let private = imp::GraphView::from_instance(self);
        if let Some((_, state)) = private.links.borrow_mut().get_mut(&link_id) {
            *state = active;
            self.queue_draw();
        } else {
            warn!("Link state changed on unknown link (id={})", link_id);
        }
    }
    pub fn remove_link(&self, id: u32) {
        let private = imp::GraphView::from_instance(self);
        let mut links = private.links.borrow_mut();
@@ -245,24 +351,37 @@ impl GraphView {
        self.queue_draw();
    }
-    pub fn set_dragged(&self, widget: Option<gtk::Widget>) {
+    /// Get the position of the specified node inside the graphview.
-        *imp::GraphView::from_instance(self).dragged.borrow_mut() = widget;
+    pub(super) fn get_node_position(&self, node: &gtk::Widget) -> (f32, f32) {
        let layout_manager = self
            .layout_manager()
            .expect("Failed to get layout manager")
            .dynamic_cast::<gtk::FixedLayout>()
            .expect("Failed to cast to FixedLayout");
        let node = layout_manager
            .layout_child(node)
            .dynamic_cast::<gtk::FixedLayoutChild>()
            .expect("Could not cast to FixedLayoutChild");
        node.transform()
            .expect("Failed to obtain transform from layout child")
            .to_translate()
    }
-    pub fn move_node(&self, node: &gtk::Widget, x: f32, y: f32) {
+    pub(super) fn move_node(&self, node: &gtk::Widget, x: f32, y: f32) {
        let layout_manager = self
-            .get_layout_manager()
+            .layout_manager()
            .expect("Failed to get layout manager")
            .dynamic_cast::<gtk::FixedLayout>()
            .expect("Failed to cast to FixedLayout");
        let transform = gsk::Transform::new()
-            .translate(&graphene::Point::new(x, y))
+            // Nodes should not be able to be dragged out of the view, so we use `max(coordinate, 0.0)` to prevent that.
            .translate(&graphene::Point::new(f32::max(x, 0.0), f32::max(y, 0.0)))
            .unwrap();
        layout_manager
-            .get_layout_child(node)
+            .layout_child(node)
            .expect("Could not get layout child")
            .dynamic_cast::<gtk::FixedLayoutChild>()
            .expect("Could not cast to FixedLayoutChild")
            .set_transform(&transform);
@@ -272,3 +391,9 @@ impl GraphView {
        self.queue_draw();
    }
 }
 impl Default for GraphView {
    fn default() -> Self {
        Self::new()
    }
 }
--- a/src/view/mod.rs
+++ b/src/view/mod.rs
@@ -1,6 +1,30 @@
 // mod.rs
 //
 // Copyright 2021 Tom A. Wagner <tom.a.wagner@protonmail.com>
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // This program is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 // GNU General Public License for more details.
 //
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 //
 // SPDX-License-Identifier: GPL-3.0-only
 //! The view presented to the user.
 //!
 //! This module contains gtk widgets needed to present the graphical user interface.
 mod graph_view;
 mod node;
-pub mod port;
+mod port;
 pub use graph_view::GraphView;
 pub use node::Node;
 pub use port::Port;
--- a/src/view/node.rs
+++ b/src/view/node.rs
@@ -1,9 +1,26 @@
-use super::graph_view::GraphView;
+// node.rs
 //
 // Copyright 2021 Tom A. Wagner <tom.a.wagner@protonmail.com>
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // This program is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 // GNU General Public License for more details.
 //
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 //
 // SPDX-License-Identifier: GPL-3.0-only
-use gtk::{glib, prelude::*, subclass::prelude::*, WidgetExt};
+use gtk::{glib, prelude::*, subclass::prelude::*};
-use pipewire::port::Direction;
+use pipewire::spa::Direction;
-use std::{collections::HashMap, rc::Rc};
+use std::collections::HashMap;
 mod imp {
    use super::*;
@@ -13,19 +30,16 @@ mod imp {
    pub struct Node {
        pub(super) grid: gtk::Grid,
        pub(super) label: gtk::Label,
-        pub(super) ports: RefCell<HashMap<u32, Rc<crate::view::port::Port>>>,
+        pub(super) ports: RefCell<HashMap<u32, crate::view::port::Port>>,
-        pub(super) num_ports_in: Cell<u32>,
+        pub(super) num_ports_in: Cell<i32>,
-        pub(super) num_ports_out: Cell<u32>,
+        pub(super) num_ports_out: Cell<i32>,
    }
    #[glib::object_subclass]
    impl ObjectSubclass for Node {
        const NAME: &'static str = "Node";
        type Type = super::Node;
        type ParentType = gtk::Widget;
        type Instance = glib::subclass::simple::InstanceStruct<Self>;
        type Class = glib::subclass::simple::ClassStruct<Self>;
        glib::object_subclass!();
        fn class_init(klass: &mut Self::Class) {
            klass.set_layout_manager_type::<gtk::BinLayout>();
@@ -37,35 +51,6 @@ mod imp {
            grid.attach(&label, 0, 0, 2, 1);
            let motion_controller = gtk::EventControllerMotion::new();
            motion_controller.connect_enter(|controller, _, _| {
                // Tell the graphview that the Node is the target of a drag when the mouse enters its label
                let widget = controller
                    .get_widget()
                    .expect("Controller with enter event has no widget")
                    .get_ancestor(super::Node::static_type())
                    .expect("Node label does not have a node ancestor widget");
                widget
                    .get_ancestor(GraphView::static_type())
                    .expect("Node with enter event is not on graph")
                    .dynamic_cast::<GraphView>()
                    .unwrap()
                    .set_dragged(Some(widget));
            });
            motion_controller.connect_leave(|controller| {
                // Tell the graphview that the Node is no longer the target of a drag when the mouse leaves.
                // FIXME: Check that we are the current target before setting none.
                controller
                    .get_widget()
                    .expect("Controller with leave event has no widget")
                    .get_ancestor(GraphView::static_type())
                    .expect("Node with leave event is not on graph")
                    .dynamic_cast::<GraphView>()
                    .unwrap()
                    .set_dragged(None);
            });
            label.add_controller(&motion_controller);
            // Display a grab cursor when the mouse is over the label so the user knows the node can be dragged.
            label.set_cursor(gtk::gdk::Cursor::from_name("grab", None).as_ref());
@@ -111,46 +96,38 @@ impl Node {
    pub fn add_port(&mut self, id: u32, port: super::port::Port) {
        let private = imp::Node::from_instance(self);
-        match port.direction {
+        match port.direction() {
            Direction::Input => {
                private
                    .grid
-                    .attach(&port.widget, 0, private.num_ports_in.get() as i32 + 1, 1, 1);
+                    .attach(&port, 0, private.num_ports_in.get() + 1, 1, 1);
                private.num_ports_in.set(private.num_ports_in.get() + 1);
            }
            Direction::Output => {
-                private.grid.attach(
+                private
-                    &port.widget,
+                    .grid
-                    1,
+                    .attach(&port, 1, private.num_ports_out.get() + 1, 1, 1);
                    private.num_ports_out.get() as i32 + 1,
                    1,
                    1,
                );
                private.num_ports_out.set(private.num_ports_out.get() + 1);
            }
        }
-        private.ports.borrow_mut().insert(id, Rc::new(port));
+        private.ports.borrow_mut().insert(id, port);
    }
-    pub fn get_port(&self, id: u32) -> Option<Rc<super::port::Port>> {
+    pub fn get_port(&self, id: u32) -> Option<super::port::Port> {
        let private = imp::Node::from_instance(self);
-        private
+        private.ports.borrow_mut().get(&id).cloned()
            .ports
            .borrow_mut()
            .get(&id)
            .map(|port_rc| port_rc.clone())
    }
    pub fn remove_port(&self, id: u32) {
        let private = imp::Node::from_instance(self);
        if let Some(port) = private.ports.borrow_mut().remove(&id) {
-            match port.direction {
+            match port.direction() {
                Direction::Input => private.num_ports_in.set(private.num_ports_in.get() - 1),
                Direction::Output => private.num_ports_in.set(private.num_ports_out.get() - 1),
            }
-            port.widget.unparent();
+            port.unparent();
        }
    }
 }
--- a/src/view/port.rs
+++ b/src/view/port.rs
@@ -1,16 +1,209 @@
-/// Graphical representation of a pipewire port.
+// port.rs
-pub struct Port {
+//
-    pub(super) widget: gtk::Button,
+// Copyright 2021 Tom A. Wagner <tom.a.wagner@protonmail.com>
-    pub id: u32,
+//
-    pub direction: pipewire::port::Direction,
+// This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // This program is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 // GNU General Public License for more details.
 //
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 //
 // SPDX-License-Identifier: GPL-3.0-only
 use gtk::{
    gdk,
    glib::{self, clone, subclass::Signal},
    prelude::*,
    subclass::prelude::*,
 };
 use log::{trace, warn};
 use pipewire::spa::Direction;
 use crate::MediaType;
 /// A helper struct for linking a output port to an input port.
 /// It carries the output ports id.
 #[derive(Clone, Debug, glib::Boxed)]
 #[boxed_type(name = "HelvumForwardLink")]
 struct ForwardLink(u32);
 /// A helper struct for linking an input to an output port.
 /// It carries the input ports id.
 #[derive(Clone, Debug, glib::Boxed)]
 #[boxed_type(name = "HelvumReversedLink")]
 struct ReversedLink(u32);
 mod imp {
    use once_cell::{sync::Lazy, unsync::OnceCell};
    use pipewire::spa::Direction;
    use super::*;
    /// Graphical representation of a pipewire port.
    #[derive(Default)]
    pub struct Port {
        pub(super) label: OnceCell<gtk::Label>,
        pub(super) id: OnceCell<u32>,
        pub(super) direction: OnceCell<Direction>,
    }
    #[glib::object_subclass]
    impl ObjectSubclass for Port {
        const NAME: &'static str = "Port";
        type Type = super::Port;
        type ParentType = gtk::Widget;
        fn class_init(klass: &mut Self::Class) {
            klass.set_layout_manager_type::<gtk::BinLayout>();
            // Make it look like a GTK button.
            klass.set_css_name("button");
        }
    }
    impl ObjectImpl for Port {
        fn dispose(&self, _obj: &Self::Type) {
            if let Some(label) = self.label.get() {
                label.unparent()
            }
        }
        fn signals() -> &'static [Signal] {
            static SIGNALS: Lazy<Vec<Signal>> = Lazy::new(|| {
                vec![Signal::builder(
                    "port-toggled",
                    // Provide id of output port and input port to signal handler.
                    &[<u32>::static_type().into(), <u32>::static_type().into()],
                    // signal handler sends back nothing.
                    <()>::static_type().into(),
                )
                .build()]
            });
            SIGNALS.as_ref()
        }
    }
    impl WidgetImpl for Port {}
 }
 glib::wrapper! {
    pub struct Port(ObjectSubclass<imp::Port>)
        @extends gtk::Widget;
 }
 impl Port {
-    pub fn new(id: u32, name: &str, direction: pipewire::port::Direction) -> Self {
+    pub fn new(id: u32, name: &str, direction: Direction, media_type: Option<MediaType>) -> Self {
-        Self {
+        // Create the widget and initialize needed fields
-            widget: gtk::Button::with_label(name),
+        let res: Self = glib::Object::new(&[]).expect("Failed to create Port");
-            id,
+
-            direction,
+        let private = imp::Port::from_instance(&res);
        private.id.set(id).expect("Port id already set");
        private
            .direction
            .set(direction)
            .expect("Port direction already set");
        let label = gtk::Label::new(Some(name));
        label.set_parent(&res);
        private
            .label
            .set(label)
            .expect("Port label was already set");
        // Add a drag source and drop target controller with the type depending on direction,
        // they will be responsible for link creation by dragging an output port onto an input port or the other way around.
        // FIXME: We should protect against different media types, e.g. it should not be possible to drop a video port on an audio port.
        // The port will simply provide its pipewire id to the drag target.
        let drag_src = gtk::DragSource::builder()
            .content(&gdk::ContentProvider::for_value(&match direction {
                Direction::Input => ReversedLink(id).to_value(),
                Direction::Output => ForwardLink(id).to_value(),
            }))
            .build();
        drag_src.connect_drag_begin(move |_, _| {
            trace!("Drag started from port {}", id);
        });
        drag_src.connect_drag_cancel(move |_, _, _| {
            trace!("Drag from port {} was cancelled", id);
            false
        });
        res.add_controller(&drag_src);
        // The drop target will accept either a `ForwardLink` or `ReversedLink` depending in its own direction,
        // and use it to emit its `port-toggled` signal.
        let drop_target = gtk::DropTarget::new(
            match direction {
                Direction::Input => ForwardLink::static_type(),
                Direction::Output => ReversedLink::static_type(),
            },
            gdk::DragAction::COPY,
        );
        match direction {
            Direction::Input => {
                drop_target.connect_drop(
                    clone!(@weak res as this => @default-panic, move |drop_target, val, _, _| {
                        if let Ok(ForwardLink(source_id)) = val.get::<ForwardLink>() {
                            // Get the callback registered in the widget and call it
                            drop_target
                                .widget()
                                .emit_by_name::<()>("port-toggled", &[&source_id, &this.id()]);
                        } else {
                            warn!("Invalid type dropped on ingoing port");
                        }
                        true
                    }),
                );
            }
            Direction::Output => {
                drop_target.connect_drop(
                    clone!(@weak res as this => @default-panic, move |drop_target, val, _, _| {
                        if let Ok(ReversedLink(target_id)) = val.get::<ReversedLink>() {
                            // Get the callback registered in the widget and call it
                            drop_target
                                .widget()
                                .emit_by_name::<()>("port-toggled", &[&this.id(), &target_id]);
                        } else {
                            warn!("Invalid type dropped on outgoing port");
                        }
                        true
                    }),
                );
            }
        }
        res.add_controller(&drop_target);
        // Display a grab cursor when the mouse is over the port so the user knows it can be dragged to another port.
        res.set_cursor(gtk::gdk::Cursor::from_name("grab", None).as_ref());
        // Color the port according to its media type.
        match media_type {
            Some(MediaType::Video) => res.add_css_class("video"),
            Some(MediaType::Audio) => res.add_css_class("audio"),
            Some(MediaType::Midi) => res.add_css_class("midi"),
            None => {}
        }
        res
    }
    pub fn id(&self) -> u32 {
        let private = imp::Port::from_instance(self);
        private.id.get().copied().expect("Port id is not set")
    }
    pub fn direction(&self) -> &Direction {
        let private = imp::Port::from_instance(self);
        private.direction.get().expect("Port direction is not set")
    }
 }
Author	SHA1	Message	Date
Tom A. Wagner	094681637e	Release v0.3.4	2022-02-02 10:08:12 +01:00
Tom A. Wagner	6f92fbdb8f	readme: Add flathub badge	2022-01-31 13:32:03 +01:00
Tom A. Wagner	e38426c09f	Update dependencies, fix segmentation fault Updating glib to 0.15.4 fixes a segmentation fault that could occur when logging a message with glib structured logging.	2022-01-31 13:17:55 +01:00
Tom A. Wagner	85e249cb32	Release 0.3.3	2022-01-28 13:49:49 +01:00
Tom A. Wagner	c54aed2e14	Update dependencies	2022-01-28 13:49:49 +01:00
Tom A. Wagner	6da232debf	meson: Fix incorrect output file name This fixes a typo from `96c61e43` that caused the binary to be generated with the wrong name.	2022-01-28 13:48:46 +01:00
Tom A. Wagner	96c61e43d2	meson: Remove custom build scripts	2022-01-28 13:01:35 +01:00
Tom A. Wagner	872ef7890d	readme: Credit gtk-rust-template	2022-01-28 12:11:32 +01:00
Tom A. Wagner	76ad8d11d7	Change application id to org.pipewire.Helvum	2022-01-28 10:14:21 +01:00
Tom A. Wagner	4075b66865	deps: Update gtk-rs to latest release	2022-01-17 12:00:00 +01:00
Tom A. Wagner	96182826e4	logging: Use glib as `log` backend instead of `env_logger`. This makes log output use the same logger as gtk itself and as most other gtk applications	2022-01-11 12:15:14 +01:00
Mihai Fufezan	e1fbb0cf49	Use gtk4-update-icon-cache instead of gtk3 one	2021-12-18 19:50:39 +00:00
Alireza Haghshenas	3653f2bb11	Emphasized that the `flatpak-builder` command needs be run inside a local clone of the project	2021-12-10 04:34:49 +00:00
Tom A. Wagner	56523f1b30	docs: Add documentation for making a release	2021-12-01 19:56:17 +01:00
Tom A. Wagner	7818bed159	Add appstream metadata file	2021-12-01 19:56:17 +01:00
Tom A. Wagner	c1ec56e115	Release 0.3.2	2021-11-30 18:25:58 +01:00
Tom A. Wagner	110e9ef67f	meson: Add dist script to vendor cargo dependencies for offline builds	2021-11-30 09:59:56 +01:00
Jan Beich	3c507683b7	build-aux: relax shebang in cargo.sh after `7b1b5ea336` /bin/sh: /bin/bash: not found	2021-11-27 21:57:03 +00:00
Thomas Rosendal	1d1f8bd3d7	Add instruction to add the flatpak remote 'flathub'	2021-11-25 07:59:45 +00:00
Sebastian Grabowski	b25f6f9abb	Update the extension versions in flatpak build instructions to 21.08 The extensions need to match the SDK version, that was updated to org.gnome.Sdk//41 in Commit `e5e02b13`. (Version 41 is based on org.freedesktop.Sdk//21.08)	2021-11-24 17:03:23 +01:00
Tom A. Wagner	2d51ea677e	ci: use more recent fd.o ci-templates	2021-11-24 16:11:16 +01:00
Tom A. Wagner	beb03d8b09	Update CI container for rust 1.56	2021-11-24 16:11:16 +01:00
Tom A. Wagner	502cf4476b	gtk4dep: bump to 4.4 for fixed gtk_pick when using affine transform This will be needed in a later commit for zooming in on the canvas using an affine (scaling) transformation matrix	2021-11-24 16:11:16 +01:00
Tom A. Wagner	eac973da15	Swap to rust 2021 edition and move rustc version check from meson.build to Cargo.toml	2021-11-24 16:11:16 +01:00
Tom A. Wagner	82a3e4f900	graphview: draw background automatically This removes the manual painting of the background via cairo and adds the correct color to CSS instead, which should hopefully improve performance as we do less cpu painting like this.	2021-11-24 16:11:16 +01:00
Suchipi	2cfc8e2e6f	Update build instructions to match changes in `e5e02b1387`	2021-11-19 01:10:14 +00:00
Tom A. Wagner	e5e02b1387	flatpak: Update to gnome runtime 41	2021-11-17 19:49:52 +01:00
Tom A. Wagner	396363cef1	README: Update screenshot	2021-11-17 19:49:52 +01:00
Tom A. Wagner	c887d77f64	graphview: Use #808080 as link color For good contrast in both dark and light mode, the link color is now a semi-light gray instead of complete black, which had bad contrast in dark mode and good constrast in light mode. Later, we can seperate color palettes for light and dark mode, but only together with a dark mode toggle button or system-wide darkmode toggle.	2021-11-13 20:32:40 +01:00
Tom A. Wagner	54d7ca83ae	graphview: Define link and grid colors in style.css Previously, these were defined directly in the code, but defining them in the css helps seperating theming and behaviour and makes the colors easier to tweak.	2021-11-13 20:08:47 +01:00
Tom A. Wagner	7b1b5ea336	build: fix and improve cargo.sh cargo.sh previously used bash features but only used `sh` in the shebang, and also did not properly quote some variables to avoid splitting/globbing from happening. Also, `-euo pilefail` is now set to avoid other errors that might come up.	2021-10-26 10:04:07 +02:00
Tom A. Wagner	729d4e1555	CI: Update container	2021-10-13 12:11:06 +02:00
Tom A. Wagner	ce6cab8134	Run rustfmt	2021-10-13 12:01:22 +02:00
Tom A. Wagner	8a552d0712	graphview: Add missing `};` to fix build.	2021-10-13 11:56:46 +02:00
halfbro	f76235674c	Add small control point offset to links that connect from right to left (loopbacks)	2021-10-13 09:11:10 +00:00
Tom A. Wagner	92dcfd61a1	Add gpl snippets to the start of each rust source file.	2021-10-03 11:27:36 +02:00
Tom A. Wagner	02e58e9bfa	LICENSE: Replace outdated and edited GPL with the lastest stock version. The old license file contained project specific edits, but editing the GPL text is disallowed by the fsf. The new file also contains updated links.	2021-10-03 11:14:30 +02:00
Tom A. Wagner	958fa15230	Release 0.3.1	2021-09-30 08:45:11 +02:00
Tom A. Wagner	e9753dd078	Update dependencies	2021-09-30 08:45:00 +02:00
Tom A. Wagner	dfb1b754c7	Add and install icons. This adds one new app icon and one new symbolic icon, and makes meson install these to the appropriate directories, and adds an appropriate entry in the .desktop file.	2021-09-30 08:28:06 +02:00
Tom A. Wagner	497da8b953	graphview: Do not crash when the position of a node not on the graph is requested While the position of a node not on the graph should never be requested, this seems to occur sometimes, so instead of panicking, we only log an error now, or ignore that node if it wasn't important.	2021-09-11 15:03:03 +02:00
Tom A. Wagner	da5da90352	Add .desktop file This adds a .desktop file (without icon for now), which will automatically be installed when `meson install` is run.	2021-08-29 18:41:09 +02:00
Tom A. Wagner	a8bfd8383e	buildsystem: Move to meson for building the project Meson will allow us to: - Verify the used rust compiler is recent enough - Install ressources such as a .desktop files, icons, etc.	2021-08-29 17:28:55 +02:00
Tom A. Wagner	7ef8677c4c	readme: move screenshot.png into docs/ folder	2021-08-29 16:56:56 +02:00
Roger Roger	487dc3b2d3	Group nodes into columns by major type	2021-08-18 07:23:50 +00:00
Tom A. Wagner	2ee7bca68a	Release 0.3.0	2021-08-08 09:51:55 +02:00
Tom A. Wagner	494d3a383f	Update dependencies	2021-08-08 09:51:42 +02:00
Tom A. Wagner	b719e0d2ec	Add simple flatpak manifest	2021-07-22 11:35:12 +02:00
Tom A. Wagner	f64a936dd9	Update dependencies	2021-07-18 09:58:39 +02:00
Tom A. Wagner	179665778d	view: Draw a dashed line for links that are not active	2021-07-08 13:37:37 +02:00
er888kh	be9339472e	First nodes that GraphView::add_node creates, get pushed to the left side of the screen. So by adding a constant offset, we can avoid having possible links that are partly out of the view just after starting the program	2021-07-06 09:39:34 +00:00
Tom A. Wagner	e29ffdeea8	view: Port: Do not inherit from gtk::Button We do not need any button functionality, so it is more appropriate to inherit directly from gtk::Widget	2021-07-06 11:01:20 +02:00
Tom A. Wagner	add1a96b75	Deduplicate port dragging code and add some extra logging	2021-07-06 10:23:20 +02:00
Tom A. Wagner	9445e173f9	view: ports: Improve linking between ports. Links can now created by dragging in both directions, so now from an input port to an output port, too. The drag-n-drop handlers now use dedicated types for each direction, so that no mismatched things can be dropped on each other.	2021-06-28 13:54:53 +02:00
Tom A. Wagner	58794fe123	Remove unneeded Rc, Port is now a refcounted gobject	2021-06-28 13:29:46 +02:00
Tom A. Wagner	8d6fbe2997	Remove outdated doc comment	2021-06-28 13:29:46 +02:00
Tom A. Wagner	b0bf5e5281	Slightly improve logging	2021-06-28 13:29:46 +02:00
Tom A. Wagner	edc4064009	graphview: Place link curve control points more dynamically Control points are now offset by half the x distance of the start and end points instead of a constant, which makes the curve scale better with varying distance.	2021-06-28 10:48:09 +02:00
Tom A. Wagner	58cdcd859b	graphview: Draw links in front of nodes, instead of behind them.	2021-06-26 12:34:48 +02:00
Tom A. Wagner	7977481689	Fix some pedantic clippy warnings	2021-06-26 12:10:36 +02:00
Tom A. Wagner	f09fd596c8	Update dependencies§	2021-06-25 15:40:17 +02:00
Tom A. Wagner	1247b29bae	Use pipewire from crates.io The newest release contains everything we need, so we can use the crates.io version again.	2021-06-25 15:38:54 +02:00
Tom A. Wagner	74ffb06b40	Use gtk4-rs from crates.io instead from their git. The gtk4 crate finally had its first release, so we no longer have to use their git repository directly.	2021-06-25 15:06:41 +02:00
Tom A. Wagner	81467154d9	Readme.md: Replace "Packages" section with repology badge, add license section	2021-06-07 16:03:50 +02:00
Tom A. Wagner	46b2175a78	Release v0.2.1	2021-06-06 20:44:10 +02:00
Tom A. Wagner	9aeea6b108	Update dependencies	2021-06-06 20:42:00 +02:00
Tom A. Wagner	c8f94ae302	Use link info callback instead of properties to get ids. While the properties for a links node ids are not always set, they always are in the link info. Also, the work done in this commit will easily allow to get the format of links and ports later, so that we can get the format of them much more reliably, and we can also get notified of changes to an existing global via the info callback.	2021-06-06 20:28:19 +02:00
Tom A. Wagner	92101d860c	Update ARCHITECTURE.md to reflect state having moved to the pipewire thread	2021-06-06 09:36:57 +02:00
Tom A. Wagner	907ef328d2	Move state to pipewire thread instead of the gtk thread. This will allow easier state-keeping later, when setting up info-listeners on structs.	2021-06-06 09:20:07 +02:00
Tom A. Wagner	118c1ca28c	Get node_from, node_to ids from state instead of props when a new link appears. This is more reliable than assuming the link carries the id of its nodes, as there have been cases where a link was created without those properties set. Instead, we can just pull them from the state via the port ids of the link.	2021-06-04 10:30:31 +02:00
Tom A. Wagner	a9aec985b0	pipewire: Edit fixme about port media type	2021-05-25 22:45:13 +02:00
Tom A. Wagner	dce228ff60	Update dependencies Glib MainContext is now aquired manually because a change in gtk-rs would lead to a panic when attaching the receiver otherwise, because gtk::init() doesn't "leak" the default main context anymore.	2021-05-22 14:00:51 +02:00
Jan Vanmullem	24fd54affe	references both AUR release & git packages	2021-05-18 16:25:49 +02:00
Mathias Rav	3cd19f2d1d	When dragging a node, don't snap its top-left corner to the cursor Revamp the node dragging implementation, moving it into the GraphView widget. When a drag is initiated, the node widget's current position is stored. Whenever the drag gesture is updated, the node widget's position is set by adding the relative drag vector to the position at the start of the drag. A drag gesture on the node widget rather than the GraphView widget was considered, but this seems to lead to a weird flickering effect when the node is moved while the drag gesture on the node is active. To avoid interfering with the drag handlers on the ports, check if the GraphView drag gesture targets a port, in which case the handler does nothing.	2021-05-10 18:21:00 +00:00
Mathias Rav	6d60095da8	Move CSS to its own file	2021-05-09 21:53:27 +02:00
Tom A. Wagner	0cee4b0ea5	Release 0.2.0	2021-05-08 20:09:11 +02:00
Tom A. Wagner	a9cd428a5a	Change cursor to grab hand over output port. This lets the user know the port can be dragged to create a link.	2021-05-08 18:44:50 +02:00
Tom A. Wagner	a5d8c871ee	Update dependencies	2021-05-08 18:42:49 +02:00
Tom A. Wagner	1c69dc85fb	Update README.md planned features section	2021-05-08 18:13:51 +02:00
Tom A. Wagner	13f02ad317	Toggle links on and off when ports are connected by the user. This extends the `Application` struct to keep more advanced state. This state is then used to determine the needed information to create or delete a link between the two connected ports. A message to create/delete the link is then send to the pipewire thread, which executed the request.	2021-05-08 18:06:52 +02:00
Tom A. Wagner	be240231c0	Merge `Controller` and `View` structs into one `Application` struct. The `View` sturct was mostly a layer of indirection, and the controller benefitted by absorbing the gtk::Application subclass parts, so now those two are merged into a new gtk::Application subclass.	2021-05-08 18:06:52 +02:00
Tom A. Wagner	2cc684d57c	Turn `struct View` into a gtk::Application subclass. This lets us keep multiple reference-counted copies easier, and lets us emit signals to the controller.	2021-05-08 18:06:52 +02:00
Tom A. Wagner	b5071c09a0	Emit "link-toggled" signal when two ports widgets are connected	2021-05-08 18:06:37 +02:00
Tom A. Wagner	08283bb995	Update CI to Fedora 34 and Rust 1.51	2021-05-06 09:36:24 +02:00
Tom A. Wagner	076fec7eb4	Modify architecture to run pipewire loop in second thread. The pipewire loop now runs without interruption in a second thread and communicates with the GTK thread via a channel in each direction, instead of checking for events once a second and using callbacks. This allows changes to appear instantly in the view, instead of having to wait.	2021-05-05 21:48:00 +02:00
Tom A. Wagner	75aa0a30d0	Turn view::port::Port into a gtk::Button subclass	2021-04-02 14:53:58 +02:00
Tom A. Wagner	9b448f0a30	view: Add some comments to `View` struct	2021-04-01 16:24:21 +02:00
Tom A. Wagner	2cb155c5ee	view: Refactor view to have a manager `View` struct. The view struct creates, manages and runs the view, and handles all communication with components outside of the view.	2021-03-31 10:44:04 +02:00
Tom A. Wagner	48821be18d	Move port coloring into view The controller still determines the ports media type, but instead of coloring the port itself, the media type is passed to the constructor, which then colors the port.	2021-03-28 21:03:43 +02:00
Tom A. Wagner	269ce18b29	Add overview of planned architecture in docs/architecture.md The new architecture.md file contains a birds-eye overview of the top-level architecture using box-drawing characters, but does not go into detail yet.	2021-03-28 19:24:25 +02:00
Tom A. Wagner	9519eefa6e	Change architecture to controller-centered arch struct PipewireConnection is now decoupled from any other components, another component (the controller) can receive updates by registering a callback. struct PipewireState has been refactored to a struct Controller. It still keeps state and manages the view, but now also actively requests updates from the pipewire connection via callback.	2021-03-28 19:04:57 +02:00
Tom A. Wagner	d75dee5ea8	Update dependencies This updates all crates to their newest release. For pipewire-rs, this includes bumping the version to 0.3, which means this comment has to fix a few breaking changes, but nothing big. 0.3 also lets us create and delete remote objects, which will be needed for link creation and deletion.	2021-03-27 19:57:44 +01:00
Emmanuel Gil Peyrot	aab1f1bde3	Add a ^Q accel to quit This is a somewhat standard shortcut used in many GTK applications.	2021-03-19 15:23:48 +00:00
Tom A. Wagner	b417ad9827	Update project name in LICENSE	2021-03-14 12:35:24 +01:00
Tom A. Wagner	85ebbda5c9	Add CI Partly based on pipewire-rs CI	2021-03-14 12:18:38 +01:00
Emmanuel Gil Peyrot	3fccff041a	README: Add a link to the AUR package, for ArchLinux users	2021-03-14 06:51:48 +00:00
Emmanuel Gil Peyrot	c414e5cac4	README: Remove last mention of the previous name	2021-03-14 06:51:48 +00:00
Emmanuel Gil Peyrot	279c792345	Update to build with latest glib glib replaced its glib::object_subclass!() macro with a #[glib::object_subclass] attribute, to simplify a bunch of things. See `fdc8459b39`	2021-03-14 00:25:08 +01:00
Tom A. Wagner	b348339b4e	Update dependencies, use pipewire-rs crates from crates.io	2021-03-12 18:04:08 +01:00
Tom A. Wagner	f0d85b7ed3	Prepare Cargo.toml for crates.io publication	2021-03-12 17:55:57 +01:00
Tom A. Wagner	7f4778cb81	Update readme for projet namechange and colored ports	2021-03-12 17:33:02 +01:00
Tom A. Wagner	528694b63e	Change application name to 'Helvum'	2021-03-12 17:30:26 +01:00
Tom A. Wagner	27aa39d4ab	Update requirements in README	2021-02-20 18:32:17 +01:00
Guillaume Desmottes	5784275d32	fix clippy warnings	2021-02-14 17:24:49 +01:00
Tom A. Wagner	99b2ef274a	Update screenshot in README for colored ports	2021-02-10 19:36:10 +01:00
Tom A. Wagner	5ac535ab37	Prevent nodes from being dragged out of the graph view	2021-02-10 10:58:01 +01:00
Tom A. Wagner	ec8de4a4a7	Color ports depending on the type of data (audio,video,midi) they carry	2021-02-09 12:51:35 +01:00
Tom A. Wagner	926829de22	Update dependencies	2021-01-19 15:37:05 +01:00